Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5561]migrate tests to junit5 #6122

Merged
merged 11 commits into from
Nov 21, 2023
Merged

[#5561]migrate tests to junit5 #6122

merged 11 commits into from
Nov 21, 2023

Conversation

fspirola
Copy link
Contributor

@fspirola fspirola commented Nov 5, 2023

PR description

Fixed Issue(s)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fspirola
migrate teste from Junit4 to Junit5
483e17a 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
@fspirola
migrate test from Junit4 to Junit5
8acfad9 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
@fspirola
hyperledger#5571 besu - migrate tests from Junit4 to Junit5
61c0421 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
@fspirola
#5571migrate-tests-to-Junit5
fb889d1 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
@fspirola
#5561migrate-tests-to-Junit5
89ee664 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
@fspirola fspirola force-pushed the 5561migrate-tests-to-Junit5 branch from dd12c1f to 89ee664 Compare November 5, 2023 02:45
@fspirola
Copy link
Contributor Author

fspirola commented Nov 5, 2023

#issue5561

fab-10
fab-10 previously requested changes Nov 6, 2023
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
ethereum/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/peers/EnodeURLImplTest.java Outdated Show resolved Hide resolved
macfarla
macfarla previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla dismissed fab-10’s stale review November 8, 2023 23:25

requested changes have been made

@macfarla
Copy link
Contributor

macfarla commented Nov 9, 2023

this unit test failure seems related to your changes - you should be able to reproduce locally

Task :besu:test

RlpBlockImporterTest > blockImport() FAILED
java.lang.RuntimeException at RlpBlockImporterTest.java:80
Caused by: java.util.concurrent.CompletionException at CompletableFuture.java:315
Caused by: java.lang.IllegalStateException at RlpBlockImporter.java:230

@macfarla macfarla dismissed their stale review November 9, 2023 05:30

unit test failures

@macfarla macfarla merged commit d94ea77 into hyperledger:main Nov 21, 2023
This was referenced Nov 25, 2023
Closed
Closed
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
@fspirola @macfarla @jflo
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
1cff6b7 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
@fspirola @macfarla @jflo
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
401cbb7 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
@fspirola @macfarla @jflo
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
a85d4fe 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
@fspirola @macfarla @gfukushima
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
865370c 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

@fab-10 fab-10 fab-10 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fspirola @macfarla @fab-10