Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed PayloadTuple and made a separate class #5916

Merged

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Sep 21, 2023

adds flexibility for adding more info to the Payload object eg OperationTracer to be used by plugins

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla macfarla marked this pull request as draft September 21, 2023 02:49
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla marked this pull request as ready for review September 21, 2023 04:42
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) September 24, 2023 23:45
@macfarla macfarla disabled auto-merge September 25, 2023 04:30
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…farla/besu into payload-block-with-receipts-refactor
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@macfarla macfarla merged commit 77b34f5 into hyperledger:main Sep 26, 2023
@macfarla macfarla deleted the payload-block-with-receipts-refactor branch September 26, 2023 01:37
jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023
* renamed PayloadTuple and made a separate class

* made a record

* refactor tests to use PayloadWrapper

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
* renamed PayloadTuple and made a separate class 

* made a record

* refactor tests to use PayloadWrapper

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants