Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make referencetests build script Windows friendly #5789

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 23, 2023

PR description

#5774 broken builds on Windows due to the different separation char, this PR just replace the '/' with the system separator char as provided by the jvm

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 enabled auto-merge (squash) August 23, 2023 11:00
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10 fab-10 merged commit cd5998d into hyperledger:main Aug 23, 2023
@fab-10 fab-10 deleted the fix-referencetests-build-on-windows branch August 24, 2023 08:29
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants