switch RlpBlockImporter tests to Junit5 #5704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi @0xBlockPay you'll need to add signoff to each commit to make the DCO happy - you should be able to follow the instructions here https://github.com/hyperledger/besu/pull/5704/checks?check_run_id=15037098648 |
663a380 to
63e6bb1
Compare
|
Can I migrate to Junit5 other test files in besu module ? |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <jaguzik@e-science.pl> Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
Signed-off-by: 0xBlockPay <0xblockpay@gmail.com>
happy for you to use your judgement - as long as PRs are less than 100 files! |
|
closing this one - due to conflicts with main branch it's prob easier to start from scratch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate RlpBlockImporterTest from JUnit 4.0 to JUnit 5.0 #5571
Fixed Issue(s)
#5571