Feature addition for tracing private transactions

[NickSneo]

PR description

PR for adding priv_traceTransaction API

Fixed Issue(s)

#5280

[github-actions]

• I thought about documentation and added the doc-change-required label to this PR if updates are required.
• I thought about the changelog and included a changelog update if required.
• If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

[macfarla]

@NickSneo for context can you add notes on any testing you've done with this in privacy-enabled networks?

[NickSneo]

@NickSneo for context can you add notes on any testing you've done with this in privacy-enabled networks?

Hey @macfarla , sorry for the delay in replying
I tested it with privacy enabled network. Created a privacy group, deployed a private contract and did a private transaction. Then called the priv_traceTransaction api using node with access to private tx -

curl -X POST --data '{"jsonrpc": "2.0", "method": "priv_traceTransaction","params": ["4tlg6LYuf3gd2FnFtamTB/J7KxS3YfJOR/Hej4MQS9s=","0x0e660fd71d6229d172de81a7d2ad234034c1b9ad58798b72493a9ede5d2e22df"],"id": 1}' http://127.0.0.1:8545
{
  "jsonrpc" : "2.0",
  "id" : 1,
  "result" : [ {
    "action" : {
      "callType" : "call",
      "from" : "0x7ee801898161f84fba714bdbb4a388ebd49273fd",
      "input" : "0x6057361d00000000000000000000000000000000000000000000000000000000000003e8",
      "to" : "0x13acff278c623b014359eca99e6120515fde42a9",
      "value" : "0x0"
    },
    "blockHash" : "0x361ba4389cdcfb74565bb99e66a4dd53cc6644369c9801e5d4e79bff319b7976",
    "blockNumber" : 2365,
    "result" : {
      "gasUsed" : "0x0",
      "output" : "0x"
    },
    "subtraces" : 0,
    "traceAddress" : [ ],
    "transactionHash" : "0x0e660fd71d6229d172de81a7d2ad234034c1b9ad58798b72493a9ede5d2e22df",
    "type" : "call"
  } ]
}

Then I called the same api from node with no access to private tx -

curl -X POST --data '{"jsonrpc": "2.0", "method": "priv_traceTransaction","params": ["4tlg6LYuf3gd2FnFtamTB/J7KxS3YfJOR/Hej4MQS9s=","0x0e660fd71d6229d172de81a7d2ad234034c1b9ad58798b72493a9ede5d2e22df"],"id": 1}' http://127.0.0.1:8546
{
  "jsonrpc" : "2.0",
  "id" : 1,
  "result" : [ ]
}

Seems the API is working fine. Planning to add the tests for this feature in another PR, since this PR is already very big

[NickSneo]

Hey @macfarla , can you please review the PR
Thanks!

@NickSneo for context can you add notes on any testing you've done with this in privacy-enabled networks?

Hey @macfarla , sorry for the delay in replying I tested it with privacy enabled network. Created a privacy group, deployed a private contract and did a private transaction. Then called the priv_traceTransaction api using node with access to private tx -

curl -X POST --data '{"jsonrpc": "2.0", "method": "priv_traceTransaction","params": ["4tlg6LYuf3gd2FnFtamTB/J7KxS3YfJOR/Hej4MQS9s=","0x0e660fd71d6229d172de81a7d2ad234034c1b9ad58798b72493a9ede5d2e22df"],"id": 1}' http://127.0.0.1:8545
{
  "jsonrpc" : "2.0",
  "id" : 1,
  "result" : [ {
    "action" : {
      "callType" : "call",
      "from" : "0x7ee801898161f84fba714bdbb4a388ebd49273fd",
      "input" : "0x6057361d00000000000000000000000000000000000000000000000000000000000003e8",
      "to" : "0x13acff278c623b014359eca99e6120515fde42a9",
      "value" : "0x0"
    },
    "blockHash" : "0x361ba4389cdcfb74565bb99e66a4dd53cc6644369c9801e5d4e79bff319b7976",
    "blockNumber" : 2365,
    "result" : {
      "gasUsed" : "0x0",
      "output" : "0x"
    },
    "subtraces" : 0,
    "traceAddress" : [ ],
    "transactionHash" : "0x0e660fd71d6229d172de81a7d2ad234034c1b9ad58798b72493a9ede5d2e22df",
    "type" : "call"
  } ]
}

Then I called the same api from node with no access to private tx -

curl -X POST --data '{"jsonrpc": "2.0", "method": "priv_traceTransaction","params": ["4tlg6LYuf3gd2FnFtamTB/J7KxS3YfJOR/Hej4MQS9s=","0x0e660fd71d6229d172de81a7d2ad234034c1b9ad58798b72493a9ede5d2e22df"],"id": 1}' http://127.0.0.1:8546
{
  "jsonrpc" : "2.0",
  "id" : 1,
  "result" : [ ]
}

Seems the API is working fine. Planning to add the tests for this feature in another PR, since this PR is already very big

[NickSneo]

Hey @pinges , can you please review this PR?
Thanks!

[macfarla]

won't chainedUpdater always be null at this point since it doesn't get set until below?

[NickSneo]

I am using the same logic as used in BlockTracer, just added extra logic for PrivateTransaction type and private world states.
Also I guess it will be null for first transaction only, once updater is set it will reuse it

[NickSneo]

besu/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/processor/BlockTracer.java

Line 59 in 7605351

if (chainedUpdater == null) {

[NickSneo]

Closing this PR.
Created a new PR for this feature - #6161