Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule shanghaiTime for Mainnet and configure forkId for tests #5230

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Schedule shanghaiTime for Mainnet and configure forkId for tests #5230

merged 2 commits into from
Mar 17, 2023

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Mar 16, 2023 •
edited
Loading

🦉

@siladu
Schedule shanghaiTime for Mainnet and configure forkId for tests
4966d32 
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu enabled auto-merge March 16, 2023 21:38
@siladu siladu disabled auto-merge March 16, 2023 21:38
jframe
jframe approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Mar 16, 2023 •
edited by siladu
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.

@siladu
Add changelog
859c650 
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu
Copy link
Contributor Author

siladu commented Mar 17, 2023

Spec: ethereum/execution-specs#727

@siladu siladu enabled auto-merge March 17, 2023 00:26
@siladu siladu added this pull request to the merge queue Mar 17, 2023
Merged via the queue into hyperledger:main with commit e6395c3 Mar 17, 2023
@siladu siladu deleted the shanghai-mainnet-schedule branch March 17, 2023 00:56
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@siladu @elenduuche
Schedule shanghaiTime for Mainnet and configure forkId for tests (hyp…
236eaa2 
…erledger#5230)

🦉
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@siladu @eum602
Schedule shanghaiTime for Mainnet and configure forkId for tests (hyp…
b7133a5 
…erledger#5230)

🦉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

@jflo jflo jflo approved these changes

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siladu @shemnon @jflo @jframe