Store db metadata file in the root data directory. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
The database metadata file should be stored in the root data directory rather than the database subdirectory. The database subdirectory is owned by the database itself and should not be directly manipulated by the node. - first look in the data directory for the metadata file - if the metadata file is found there, process it as normal - if no metadata file is found in the root directory, look in the database subdirectory - if the file is found here, copy it to the root directory, and run based on the root directory version Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
…metadata-root-data-dir Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
shemnon
approved these changes
Sep 24, 2019
besu/src/main/java/org/hyperledger/besu/services/BesuConfigurationImpl.java
Show resolved
Hide resolved
...ava/org/hyperledger/besu/plugin/services/storage/rocksdb/configuration/DatabaseMetadata.java
Show resolved
Hide resolved
...ava/org/hyperledger/besu/plugin/services/storage/rocksdb/configuration/DatabaseMetadata.java
Show resolved
Hide resolved
AbdelStark
commented
Sep 24, 2019
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The database metadata file should be stored in the root data directory rather than the database subdirectory. The database subdirectory is owned by the database itself and should not be directly manipulated by the node.
Fixed Issue(s)