-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 1.2.4 changes #39
Conversation
Signed-off-by: Madeline <madeline.murray@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity, could we please add the block numbers for each of the networks? Thanks!
CHANGELOG.md
Outdated
|
||
### Additions and Improvements | ||
|
||
- Add Istanbul block for Rinkeby [\#35](https://github.com/hyperledger/besu/pull/35) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Istanbul fork block (5435345) for Rinkeby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CHANGELOG.md
Outdated
### Additions and Improvements | ||
|
||
- Add Istanbul block for Rinkeby [\#35](https://github.com/hyperledger/besu/pull/35) | ||
- Add Istanbul block for Goerli [\#27](https://github.com/hyperledger/besu/pull/27) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Istanbul fork block (1561651) for Goerli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CHANGELOG.md
Outdated
|
||
- Add Istanbul block for Rinkeby [\#35](https://github.com/hyperledger/besu/pull/35) | ||
- Add Istanbul block for Goerli [\#27](https://github.com/hyperledger/besu/pull/27) | ||
- Add Istanbul block for Ropsten [\#26](https://github.com/hyperledger/besu/pull/26) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Istanbul fork block (6485846) for Ropsten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Madeline <madeline.murray@consensys.net>
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
f1f0fe9
to
5ccac50
Compare
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
Signed-off-by: Madeline madeline.murray@consensys.net
Added 1.2.4 changes