Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 1.2.4 changes #39

Merged
merged 5 commits into from
Sep 23, 2019
Merged

Conversation

MadelineMurray
Copy link
Contributor

Signed-off-by: Madeline madeline.murray@consensys.net

Added 1.2.4 changes

Signed-off-by: Madeline <madeline.murray@consensys.net>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@timbeiko timbeiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, could we please add the block numbers for each of the networks? Thanks!

CHANGELOG.md Outdated

### Additions and Improvements

- Add Istanbul block for Rinkeby [\#35](https://github.com/hyperledger/besu/pull/35)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Istanbul fork block (5435345) for Rinkeby

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CHANGELOG.md Outdated
### Additions and Improvements

- Add Istanbul block for Rinkeby [\#35](https://github.com/hyperledger/besu/pull/35)
- Add Istanbul block for Goerli [\#27](https://github.com/hyperledger/besu/pull/27)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Istanbul fork block (1561651) for Goerli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CHANGELOG.md Outdated

- Add Istanbul block for Rinkeby [\#35](https://github.com/hyperledger/besu/pull/35)
- Add Istanbul block for Goerli [\#27](https://github.com/hyperledger/besu/pull/27)
- Add Istanbul block for Ropsten [\#26](https://github.com/hyperledger/besu/pull/26)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Istanbul fork block (6485846) for Ropsten.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

MadelineMurray and others added 3 commits September 24, 2019 05:32
Signed-off-by: Madeline <madeline.murray@consensys.net>
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
@EdJoJob EdJoJob merged this pull request into hyperledger:master Sep 23, 2019
EdJoJob pushed a commit that referenced this pull request Sep 23, 2019
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants