-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BESU-185] - CLI Option to enable TLS client auth for JSON-RPC HTTP #340
Merged
usmansaleem
merged 10 commits into
hyperledger:master
from
usmansaleem:rpc_tls_client_auth
Jan 30, 2020
Merged
[BESU-185] - CLI Option to enable TLS client auth for JSON-RPC HTTP #340
usmansaleem
merged 10 commits into
hyperledger:master
from
usmansaleem:rpc_tls_client_auth
Jan 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following options are added --rpc-http-tls-client-auth-enabled - Enable TLS client authentication for the JSON-RPC HTTP service (default: false) --rpc-http-tls-known-clients-file - Path to file containing client's certificate common name and fingerprint for client authentication. --rpc-http-tls-ca-clients-enabled - Enable to accept clients certificate signed by a valid CA for client authentication (default: false) Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
shemnon
approved these changes
Jan 30, 2020
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Usman Saleem <usman@usmans.info>
shemnon
approved these changes
Jan 30, 2020
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
* Engine API: initial draft of EIP-6110 spec * Simplify getPayloadV6110 response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The JSON-RPC HTTP endpoint TLS related CLI option currently exposes following to automatically enable client authentication while providing facility to read client certificates fingerprints to trust them. It also automatically allows a public CA signed client certificate.
--rpc-http-tls-known-clients-file
This PR allows user to enable/disable TLS client auth and if enabled allows to provide a known-clients file as well as enabling CA signed clients. If client-auth is enabled, then user must either enable CA signed client OR provide a known-clients file. We raise an error if both CA signed clients are disabled as well as known-clients file is not specified.
Following options are added
--rpc-http-tls-client-auth-enabled - Enable TLS client authentication for the JSON-RPC HTTP service (default: false)
--rpc-http-tls-known-clients-file - Path to file containing client's certificate common name and fingerprint for client authentication.
--rpc-http-tls-ca-clients-enabled - Enable to accept clients certificate signed by a valid CA for client authentication (default: false)
Signed-off-by: Usman Saleem usman@usmans.info