Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BESU-185] - CLI Option to enable TLS client auth for JSON-RPC HTTP #340

Merged
merged 10 commits into from
Jan 30, 2020
Merged

[BESU-185] - CLI Option to enable TLS client auth for JSON-RPC HTTP #340

merged 10 commits into from
Jan 30, 2020

Conversation

usmansaleem
Copy link
Member

@usmansaleem usmansaleem commented Jan 29, 2020

PR description

The JSON-RPC HTTP endpoint TLS related CLI option currently exposes following to automatically enable client authentication while providing facility to read client certificates fingerprints to trust them. It also automatically allows a public CA signed client certificate.

--rpc-http-tls-known-clients-file

This PR allows user to enable/disable TLS client auth and if enabled allows to provide a known-clients file as well as enabling CA signed clients. If client-auth is enabled, then user must either enable CA signed client OR provide a known-clients file. We raise an error if both CA signed clients are disabled as well as known-clients file is not specified.

Following options are added

--rpc-http-tls-client-auth-enabled - Enable TLS client authentication for the JSON-RPC HTTP service (default: false)
--rpc-http-tls-known-clients-file - Path to file containing client's certificate common name and fingerprint for client authentication.
--rpc-http-tls-ca-clients-enabled - Enable to accept clients certificate signed by a valid CA for client authentication (default: false)

Signed-off-by: Usman Saleem usman@usmans.info

Following options are added

--rpc-http-tls-client-auth-enabled  - Enable TLS client authentication for the JSON-RPC HTTP service (default: false)
--rpc-http-tls-known-clients-file - Path to file containing client's certificate common name and fingerprint for client authentication.
--rpc-http-tls-ca-clients-enabled - Enable to accept clients certificate signed by a valid CA for client authentication (default: false)

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem marked this pull request as ready for review January 30, 2020 01:01
Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem merged commit eca91a9 into hyperledger:master Jan 30, 2020
@usmansaleem usmansaleem deleted the rpc_tls_client_auth branch January 30, 2020 06:48
siladu pushed a commit to siladu/besu that referenced this pull request Oct 28, 2024
* Engine API: initial draft of EIP-6110 spec

* Simplify getPayloadV6110 response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants