Log Event Streaming for Plugin API #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
shemnon
reviewed
Nov 13, 2019
| @@ -176,6 +176,10 @@ public static Address privateContractAddress( | |||
| }))); | |||
| } | |||
|
|
|||
| public static Address fromPlugin(final org.hyperledger.besu.plugin.data.Address logger) { | |||
There was a problem hiding this comment.
Should we do a type check first? There's a strong chance it is a compatible object we just can't staticly prove it.
if (logger instanceof Address) {
return (Address) logger;
} else {
return wrap(BytesValue.fromPlugin(logger));
}
shemnon
reviewed
Nov 13, 2019
| @@ -68,6 +68,10 @@ public static Hash fromHexStringLenient(final String str) { | |||
| return new Hash(Bytes32.fromHexStringLenient(str)); | |||
| } | |||
|
|
|||
| public static Hash fromPlugin(final org.hyperledger.besu.plugin.data.Hash blockHash) { | |||
| return wrap(Bytes32.fromPlugin(blockHash)); | |||
There was a problem hiding this comment.
Same type check here, and all the places we do a wrap.
shemnon
reviewed
Nov 13, 2019
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/LogWithMetadata.java
Show resolved
Hide resolved
shemnon
approved these changes
Nov 13, 2019
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
RatanRSur
commented
Nov 13, 2019
| @@ -168,6 +169,10 @@ static Bytes32 fromHexStringStrict(final String str) { | |||
| return wrap(BytesValues.fromRawHexString(str, -1, false)); | |||
| } | |||
|
|
|||
| static Bytes32 fromPlugin(final UnformattedData data) { | |||
| return wrap(data.getByteArray()); | |||
There was a problem hiding this comment.
@shemnon Would we want to leave this one as is since wrap here does runtime verification of the structure?
There was a problem hiding this comment.
If it's a Bytes32 it should already have been validated when the instance was made. If we keep wrapping this will put pressure on the garbage collector and I'd like to avoid that as much as possible. Either way.
There was a problem hiding this comment.
ah right, sounds good
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
|
👍 |
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
shemnon
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Since the blockchain can now produce LogWithMetadata in its events. We create a new listener that the plugin implementation hooks into.
There is also code that converts from the plugin types to our domain types. It's a bit forceful so I'm open to suggestions on how to make that part more elegant within Java's type system.
Fixed Issue(s)
https://pegasys1.atlassian.net/secure/RapidBoard.jspa?rapidView=28&projectKey=PIE&modal=detail&selectedIssue=PIE-1802&assignee=5ce472e018de8f0dc3552e9c&assignee=UNASSIGNED_USER_ID