[PIE-2016] Updated PoAMetricService with method to check node's address. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b903458 to
cf7a7e1
Compare
mark-terry
commented
Oct 24, 2019
| @@ -41,4 +47,11 @@ public PoAMetricServiceImpl(final BlockInterface blockInterface, final Blockchai | |||
| public Address getProposerOfBlock(final BlockHeader header) { | |||
| return this.blockInterface.getProposerOfBlock(header); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean isThisNodesAddress(final Address address) { | |||
There was a problem hiding this comment.
I'm not huge on this function name. Suggestions?
There was a problem hiding this comment.
Yeah we shouldn't add this method to the public API. It should be a method that gets the current address which can then be compared. That could be getLocalNodeAddress somewhere more generic than this, but I actually like the idea of designing the API to handle the node address and the address used as a validator to potentially be different in the future. So maybe getLocalSignerAddress?
Signed-off-by: Mark Terry <mark.terry@consensys.net>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
Engine API: refine message ordering section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Added a method to the PoAMetricService that allows plugins to check whether a given address matches the node's address.
Fixed Issue(s)
PIE-2016