javadoc, remove archive interface references, update TODO

Signed-off-by: garyschulte <garyschulte@gmail.com>
hyperledger · Sep 19, 2023 · 8e78bcb · 8e78bcb
1 parent 448d4cf
commit 8e78bcb
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 14 deletions.
diff --git a/.../core/src/main/java/org/hyperledger/besu/ethereum/bonsai/storage/flat/FlatDbStrategy.java b/.../core/src/main/java/org/hyperledger/besu/ethereum/bonsai/storage/flat/FlatDbStrategy.java
@@ -23,7 +23,6 @@
 import org.hyperledger.besu.datatypes.StorageSlotKey;
 import org.hyperledger.besu.ethereum.trie.NodeLoader;
 import org.hyperledger.besu.metrics.BesuMetricCategory;
-import org.hyperledger.besu.plugin.data.BlockHeader;
 import org.hyperledger.besu.plugin.services.MetricsSystem;
 import org.hyperledger.besu.plugin.services.metrics.Counter;
 import org.hyperledger.besu.plugin.services.storage.SegmentedKeyValueStorage;
@@ -233,13 +232,4 @@ public Map<Bytes32, Bytes> streamStorageFlatDatabase(
     pairStream.close();
     return collected;
   }
-
-  public void updateBlockContext(final BlockHeader blockHeader) {
-    // default no-op for strategies that do not care about bonsai context
-  }
-
-  public FlatDbStrategy contextSafeClone() {
-    // FlatDBStrategies that care about bonsai context changes should override this
-    return this;
-  }
 }
diff --git a/plugin-api/build.gradle b/plugin-api/build.gradle
@@ -69,7 +69,7 @@ Calculated : ${currentHash}
 tasks.register('checkAPIChanges', FileStateChecker) {
   description = "Checks that the API for the Plugin-API project does not change without deliberate thought"
   files = sourceSets.main.allJava.files
-  knownHash = 'mELgOHUFNqiqbP822m8GYuS1egIdboOaE7mxAQosIgk='
+  knownHash = 'BhqPyj1fT50NWuHTgzgCmW1ynAPj/2QiGWraq5OwgOQ='
 }
 check.dependsOn('checkAPIChanges')
 

diff --git a/.../src/main/java/org/hyperledger/besu/plugin/services/storage/SegmentedKeyValueStorage.java b/.../src/main/java/org/hyperledger/besu/plugin/services/storage/SegmentedKeyValueStorage.java
@@ -169,7 +169,7 @@ record NearestKeyValue(Bytes key, Optional<byte[]> value) {
     /**
      * Convenience method to map the Optional value to Bytes.
      *
-     * @return Optional<Bytes>
+     * @return Optional of Bytes.
      */
     public Optional<Bytes> wrapBytes() {
       return value.map(Bytes::wrap);

diff --git a/...src/main/java/org/hyperledger/besu/services/kvstore/SegmentedInMemoryKeyValueStorage.java b/...src/main/java/org/hyperledger/besu/services/kvstore/SegmentedInMemoryKeyValueStorage.java
@@ -116,8 +116,7 @@ public Optional<byte[]> get(final SegmentIdentifier segmentIdentifier, final byt
   public Optional<NearestKeyValue> getNearestTo(
       final SegmentIdentifier segmentIdentifier, final Bytes key) throws StorageException {
 
-    // TODO: this is a naive implementation which should be revisited for performance
-
+    // TODO: revisit this for sort performance
     Comparator<Map.Entry<Bytes, Optional<byte[]>>> comparing =
         Comparator.comparing(
                 (Map.Entry<Bytes, Optional<byte[]>> a) -> a.getKey().commonPrefixLength(key))