-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syncing docs #1717
Merged
alexandratran
merged 4 commits into
hyperledger:main
from
alexandratran:1715-update-syncing
Oct 21, 2024
Merged
Update syncing docs #1717
alexandratran
merged 4 commits into
hyperledger:main
from
alexandratran:1715-update-syncing
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment
Co-authored-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Signed-off-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
joaniefromtheblock
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bgravenorst
pushed a commit
to bgravenorst/besu-docs
that referenced
this pull request
Oct 22, 2024
* Update syncing docs Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> * Update options.md Co-authored-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Signed-off-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * address reviewer feedback + edits Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> --------- Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> Signed-off-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> Co-authored-by: Alexandra Tran <alexandra.tran@consensys.net> Co-authored-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
bgravenorst
added a commit
that referenced
this pull request
Oct 22, 2024
* Add tx pool CLI option. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Add extra clarification. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Address reviewer feedback. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Typo. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Fix additional typos. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Minor edits. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Update syncing docs (#1717) * Update syncing docs Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> * Update options.md Co-authored-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Signed-off-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * address reviewer feedback + edits Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> --------- Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> Signed-off-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> Co-authored-by: Alexandra Tran <alexandra.tran@consensys.net> Co-authored-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> * Update to match other Besu headings Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> --------- Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> Signed-off-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> Co-authored-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> Co-authored-by: Alexandra Tran <alexandra.tran@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR edits and rearranges the Besu syncing docs.
Issue(s) fixed
Fixes #1715
Preview