Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Hide indy-api-types from modular_libs consumers #940

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Try Hide indy-api-types from modular_libs consumers #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aries_vcx_core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ edition = "2021"
[features]
########################## DEP FLAGS ################################
# Feature flag to include the libvdrtools dependency
vdrtools_anoncreds = ["dep:libvdrtools"]
vdrtools_wallet = ["dep:libvdrtools"]
vdrtools_anoncreds = ["dep:libvdrtools", "dep:indy-api-types"]
vdrtools_wallet = ["dep:libvdrtools", "dep:indy-api-types"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really nice to have a wallet implementation which does not depend on indy-api-types as well

# Feature flag to include the 'modular library' dependencies (vdrtools alternatives; indy-vdr, indy-credx)
modular_libs = ["dep:indy-credx"]
vdr_proxy_ledger = ["modular_libs", "dep:indy-vdr-proxy-client"]
Expand All @@ -19,7 +19,7 @@ agency_client = { path = "../agency_client" }
indy-vdr = { git = "https://github.com/hyperledger/indy-vdr.git", rev = "879e29e", default-features = false, features = ["log"] }
indy-credx = { git = "https://github.com/hyperledger/indy-shared-rs", tag = "v1.0.1", optional = true }
libvdrtools = { path = "../libvdrtools", optional = true }
indy-api-types = { path = "../libvdrtools/indy-api-types" }
indy-api-types = { path = "../libvdrtools/indy-api-types", optional = true }
async-trait = "0.1.68"
futures = { version = "0.3", default-features = false }
serde_json = "1.0.95"
Expand Down
1 change: 1 addition & 0 deletions aries_vcx_core/src/errors/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ pub mod error;
mod mapping_agency_client;
#[cfg(any(feature = "modular_libs"))]
mod mapping_credx;
#[cfg(any(feature = "vdrtools_anoncreds", feature = "vdrtools_wallet"))]
mod mapping_indy_api_types;
mod mapping_indyvdr;
#[cfg(feature = "vdr_proxy_ledger")]
Expand Down