-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to convert legacy DID documents to new during deserialization #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirgee
force-pushed
the
feature/ddo-legacy-integration
branch
from
August 16, 2023 09:34
c09bc83
to
88af44d
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
…arsing Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
mirgee
force-pushed
the
feature/ddo-legacy-integration
branch
from
August 17, 2023 08:22
7c1b420
to
aef75bb
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
mirgee
force-pushed
the
feature/ddo-legacy-integration
branch
from
August 17, 2023 12:29
0e59933
to
a17a785
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
mirgee
force-pushed
the
feature/ddo-legacy-integration
branch
from
August 17, 2023 12:33
870374c
to
9bf926b
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
reviewed
Aug 17, 2023
Patrik-Stas
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a lightweight, easy-to-remove legacy DDO data structure to the
did_document_sov
crate. During the deserialization ofDidDocumentSov
, if the incoming data matches the legacy structure, it is converted toDidDocumentSov
withIndyAgent
service type.Received legacy DDO is first converted to did:peer:2 following this document, and from it then back-resolved to the new DDO format following the did:peer:2 spec.