-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parsing unqualified DIDs #936
Conversation
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
…arsing Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Codecov Report
@@ Coverage Diff @@
## main #936 +/- ##
==========================================
+ Coverage 44.16% 44.25% +0.09%
==========================================
Files 418 418
Lines 29253 29311 +58
Branches 6234 6262 +28
==========================================
+ Hits 12920 12973 +53
+ Misses 12523 12512 -11
- Partials 3810 3826 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but left some comments - consider them, otherwise feel free to merge
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Enables parsing of unqualified DIDs in
did_parser
, a temporary measure for the purposes of gracefully transitioning to using fully qualified DIDs, and will be reverted once the transition is complete.