Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing unqualified DIDs #936

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Allow parsing unqualified DIDs #936

merged 3 commits into from
Aug 16, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Aug 14, 2023

Enables parsing of unqualified DIDs in did_parser, a temporary measure for the purposes of gracefully transitioning to using fully qualified DIDs, and will be reverted once the transition is complete.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee marked this pull request as draft August 14, 2023 13:51
@mirgee mirgee marked this pull request as ready for review August 14, 2023 14:55
@mirgee mirgee marked this pull request as draft August 14, 2023 15:38
…arsing

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #936 (3f3988d) into main (773113c) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 3f3988d differs from pull request most recent head 750bf18. Consider uploading reports for the commit 750bf18 to get more accurate results

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   44.16%   44.25%   +0.09%     
==========================================
  Files         418      418              
  Lines       29253    29311      +58     
  Branches     6234     6262      +28     
==========================================
+ Hits        12920    12973      +53     
+ Misses      12523    12512      -11     
- Partials     3810     3826      +16     
Flag Coverage Δ
unittests-aries-vcx 44.25% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
did_parser/src/did.rs 0.00% <ø> (ø)

... and 18 files with indirect coverage changes

@mirgee mirgee marked this pull request as ready for review August 16, 2023 14:02
Patrik-Stas
Patrik-Stas previously approved these changes Aug 16, 2023
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but left some comments - consider them, otherwise feel free to merge

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee merged commit fcb4616 into main Aug 16, 2023
@mirgee mirgee deleted the feature/allow-unqualified-dids branch August 16, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants