Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test setup, add interface to write DIDs on ledger #921

Merged
merged 9 commits into from
Aug 15, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Aug 3, 2023

  • Add interface to write endorser DIDs on Indy ledger write_endorser_did
  • In order to reasonably implement its test test_pool_write_new_endorser_did I have refactored code related to test setup - mainly separating building "Profiles" from building and setting up wallet. This the mentioned test to create one instance of "Faber agent" with known trusteee DID, and one instance of "Faber agent" with a random did in its wallet.
  • Change libvcx function wallet_create_pairwise_did to wallet_create_and_store_did(seed: Option<&str>) - the original name is bit deceiving, sometimes you just want to generate a key even when and you are not dealing with any pairwise relationship. So this name is more general and also provide option to pass in seed for did/verkey generation.
  • Minor CI improvements - making needs declaration bit simpler and consistent
  • Added some integration tests directly to node wrapper, rather than propagating the APIs to vcxagent-core.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #921 (7012c06) into main (773113c) will increase coverage by 0.09%.
The diff coverage is 73.42%.

❗ Current head 7012c06 differs from pull request most recent head 2e54125. Consider uploading reports for the commit 2e54125 to get more accurate results

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   44.16%   44.25%   +0.09%     
==========================================
  Files         418      418              
  Lines       29253    29311      +58     
  Branches     6234     6262      +28     
==========================================
+ Hits        12920    12973      +53     
+ Misses      12523    12512      -11     
- Partials     3810     3826      +16     
Flag Coverage Δ
unittests-aries-vcx 44.25% <73.42%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/src/utils/constants.rs 0.00% <ø> (ø)
...ries_vcx/src/utils/mockdata/profile/mock_ledger.rs 0.00% <0.00%> (ø)
aries_vcx_core/src/ledger/base_ledger.rs 0.00% <ø> (ø)
aries_vcx_core/src/wallet/base_wallet.rs 0.00% <ø> (ø)
aries_vcx_core/src/wallet/indy/wallet.rs 40.60% <0.00%> (-1.74%) ⬇️
aries_vcx_core/src/ledger/indy_vdr_ledger.rs 35.80% <50.00%> (+2.68%) ⬆️
aries_vcx/src/utils/devsetup.rs 47.36% <62.90%> (-2.00%) ⬇️
aries_vcx/src/common/ledger/transactions.rs 44.93% <76.92%> (+1.94%) ⬆️
aries_vcx/tests/utils/devsetup_alice.rs 73.05% <77.77%> (-1.32%) ⬇️
aries_vcx/tests/utils/devsetup_faber.rs 81.52% <77.77%> (-0.83%) ⬇️
... and 5 more

... and 7 files with indirect coverage changes

@Patrik-Stas Patrik-Stas force-pushed the ledger/write-did branch 10 times, most recently from b2fa4d2 to 533c409 Compare August 8, 2023 16:22
@Patrik-Stas Patrik-Stas changed the base branch from purge/vdrtools-zmq to main August 10, 2023 14:34
@Patrik-Stas Patrik-Stas changed the base branch from main to purge/vdrtools-zmq August 10, 2023 14:35
Base automatically changed from purge/vdrtools-zmq to main August 10, 2023 16:04
@Patrik-Stas Patrik-Stas force-pushed the ledger/write-did branch 2 times, most recently from 97afb5f to 436db3b Compare August 11, 2023 10:38
@Patrik-Stas Patrik-Stas requested a review from mirgee August 13, 2023 19:43
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@mirgee mirgee merged commit 3321031 into main Aug 15, 2023
@mirgee mirgee deleted the ledger/write-did branch August 15, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants