-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test setup, add interface to write DIDs on ledger #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
==========================================
+ Coverage 44.16% 44.25% +0.09%
==========================================
Files 418 418
Lines 29253 29311 +58
Branches 6234 6262 +28
==========================================
+ Hits 12920 12973 +53
+ Misses 12523 12512 -11
- Partials 3810 3826 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
force-pushed
the
purge/vdrtools-zmq
branch
from
August 4, 2023 10:22
828eb2a
to
84b1241
Compare
Patrik-Stas
force-pushed
the
ledger/write-did
branch
10 times, most recently
from
August 8, 2023 16:22
b2fa4d2
to
533c409
Compare
Patrik-Stas
force-pushed
the
purge/vdrtools-zmq
branch
from
August 10, 2023 10:13
83f8cb8
to
2fbce31
Compare
mirgee
reviewed
Aug 10, 2023
mirgee
reviewed
Aug 10, 2023
mirgee
reviewed
Aug 10, 2023
mirgee
reviewed
Aug 10, 2023
Patrik-Stas
force-pushed
the
ledger/write-did
branch
from
August 10, 2023 14:31
533c409
to
4dec2c4
Compare
Patrik-Stas
force-pushed
the
ledger/write-did
branch
2 times, most recently
from
August 11, 2023 10:38
97afb5f
to
436db3b
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
ledger/write-did
branch
from
August 14, 2023 16:58
436db3b
to
7012c06
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
ledger/write-did
branch
from
August 14, 2023 20:39
7012c06
to
2e54125
Compare
mirgee
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write_endorser_did
test_pool_write_new_endorser_did
I have refactored code related to test setup - mainly separating building "Profiles" from building and setting up wallet. This the mentioned test to create one instance of "Faber agent" with known trusteee DID, and one instance of "Faber agent" with a random did in its wallet.libvcx
functionwallet_create_pairwise_did
towallet_create_and_store_did(seed: Option<&str>)
- the original name is bit deceiving, sometimes you just want to generate a key even when and you are not dealing with any pairwise relationship. So this name is more general and also provide option to pass in seed for did/verkey generation.needs
declaration bit simpler and consistentnode
wrapper, rather than propagating the APIs tovcxagent-core
.