Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor aries_vcx_core #910

Merged
merged 18 commits into from
Jul 26, 2023
Merged

Refactor aries_vcx_core #910

merged 18 commits into from
Jul 26, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jul 24, 2023

  • Small vdrtools adjustment to make indy-wallet compilable without zmq dependency (original intention of PR was to extract wallet out of vdrtools, a strategy I decided to abandon, so this dependency/feature changed in vdrtools are here just as "why not" improvement)
  • Reorganize files in aries_vcx_core such that all wallet APIs are under aries_vcx_core/wallet module
  • Reorganize aries_vcx_core to move files out of src/indy into src/anoncreds / src/ledger / src/wallet to keep things together. Previously things been a bit scatter in src/indy and other directories.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Make indy-wallet compilable without zmq dependency Make vdrtools wallet usable standalone Jul 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #910 (682a93b) into main (b49b5d9) will decrease coverage by 0.03%.
The diff coverage is 33.09%.

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   43.37%   43.34%   -0.03%     
==========================================
  Files         438      438              
  Lines       34777    34847      +70     
  Branches     7580     7606      +26     
==========================================
+ Hits        15084    15106      +22     
- Misses      15231    15259      +28     
- Partials     4462     4482      +20     
Flag Coverage Δ
unittests-aries-vcx 43.34% <33.09%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/src/common/anoncreds.rs 80.30% <ø> (ø)
aries_vcx/src/common/keys.rs 44.64% <ø> (ø)
...vcx/src/common/primitives/credential_definition.rs 55.84% <ø> (ø)
aries_vcx/src/common/primitives/mod.rs 83.49% <ø> (ø)
...es_vcx/src/common/proofs/prover/prover_internal.rs 27.27% <ø> (ø)
aries_vcx/src/common/test_utils.rs 93.54% <ø> (ø)
aries_vcx/src/core/profile/vdrtools_profile.rs 72.50% <ø> (ø)
aries_vcx/src/handlers/connection/cloud_agent.rs 70.00% <ø> (ø)
aries_vcx/src/utils/provision.rs 77.77% <ø> (ø)
aries_vcx/tests/test_agency.rs 77.60% <ø> (ø)
... and 33 more

... and 6 files with indirect coverage changes

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the refactoring/extract-vdrtools-wallet branch from 366edcd to 0e9b410 Compare July 24, 2023 12:20
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
…:prover_create_link_secret

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the refactoring/extract-vdrtools-wallet branch from 5c2c359 to 55e4c13 Compare July 25, 2023 07:13
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Make vdrtools wallet usable standalone Refactor aries_vcx_core Jul 25, 2023
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the refactoring/extract-vdrtools-wallet branch 2 times, most recently from 52b4c2f to 682a93b Compare July 25, 2023 20:11
@Patrik-Stas Patrik-Stas requested review from mirgee and bobozaur July 26, 2023 09:41
@mirgee mirgee merged commit 29cde27 into main Jul 26, 2023
@mirgee mirgee deleted the refactoring/extract-vdrtools-wallet branch July 26, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants