-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor aries_vcx_core #910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
changed the title
Make indy-wallet compilable without zmq dependency
Make vdrtools wallet usable standalone
Jul 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #910 +/- ##
==========================================
- Coverage 43.37% 43.34% -0.03%
==========================================
Files 438 438
Lines 34777 34847 +70
Branches 7580 7606 +26
==========================================
+ Hits 15084 15106 +22
- Misses 15231 15259 +28
- Partials 4462 4482 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
refactoring/extract-vdrtools-wallet
branch
from
July 24, 2023 12:20
366edcd
to
0e9b410
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
…:prover_create_link_secret Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
refactoring/extract-vdrtools-wallet
branch
from
July 25, 2023 07:13
5c2c359
to
55e4c13
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
changed the title
Make vdrtools wallet usable standalone
Refactor aries_vcx_core
Jul 25, 2023
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
refactoring/extract-vdrtools-wallet
branch
2 times, most recently
from
July 25, 2023 20:11
52b4c2f
to
682a93b
Compare
bobozaur
approved these changes
Jul 26, 2023
mirgee
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vdrtools
are here just as "why not" improvement)aries_vcx_core
such that all wallet APIs are underaries_vcx_core/wallet
modulearies_vcx_core
to move files out ofsrc/indy
intosrc/anoncreds
/src/ledger
/src/wallet
to keep things together. Previously things been a bit scatter insrc/indy
and other directories.