Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to init memory, wallet, pool separately #91

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

Patrik-Stas
Copy link
Contributor

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@Patrik-Stas Patrik-Stas force-pushed the feature/vcx-init-split branch from 98e06f1 to d82941e Compare September 18, 2020 11:08
@codecov-commenter
Copy link

Codecov Report

Merging #91 into master will increase coverage by 0.03%.
The diff coverage is 48.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   46.80%   46.83%   +0.03%     
==========================================
  Files         123      123              
  Lines       25360    25499     +139     
  Branches     6953     6988      +35     
==========================================
+ Hits        11869    11943      +74     
- Misses       9732     9779      +47     
- Partials     3759     3777      +18     
Flag Coverage Δ
#unittests 46.83% <48.32%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/utils/libindy/pool.rs 27.58% <18.75%> (+12.05%) ⬆️
libvcx/src/api/vcx.rs 61.23% <41.46%> (-3.53%) ⬇️
libvcx/src/utils/devsetup.rs 30.88% <61.53%> (+3.64%) ⬆️
libvcx/src/api/wallet.rs 49.52% <87.50%> (+0.16%) ⬆️
libvcx/src/utils/timeout.rs 100.00% <100.00%> (ø)
libvcx/src/lib.rs 33.51% <0.00%> (-0.16%) ⬇️
libvcx/src/utils/threadpool.rs 78.26% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58133b5...16ba4a2. Read the comment docs.

@Patrik-Stas Patrik-Stas changed the title WIP: Start splitting vcx init Add function to vcx init memory, wallet, pool separately Sep 18, 2020
@Patrik-Stas Patrik-Stas changed the title Add function to vcx init memory, wallet, pool separately Add functions to vcx init memory, wallet, pool separately Sep 18, 2020
@Patrik-Stas Patrik-Stas changed the title Add functions to vcx init memory, wallet, pool separately Add functions to init memory, wallet, pool separately Sep 18, 2020
@Patrik-Stas Patrik-Stas force-pushed the feature/vcx-init-split branch from 16ba4a2 to 3b978a8 Compare September 18, 2020 13:49
libvcx/src/utils/libindy/pool.rs Outdated Show resolved Hide resolved
libvcx/src/utils/libindy/pool.rs Outdated Show resolved Hide resolved
libvcx/src/utils/libindy/pool.rs Outdated Show resolved Hide resolved
libvcx/src/utils/timeout.rs Show resolved Hide resolved
agents/node/vcxagent-core/vcx-agent.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/vcx-agent.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/vcx-agent.js Outdated Show resolved Hide resolved
libvcx/src/api/vcx.rs Show resolved Hide resolved
Copy link
Contributor

@mirgee mirgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments above

@Patrik-Stas Patrik-Stas force-pushed the feature/vcx-init-split branch from 13bb001 to 18367a4 Compare September 20, 2020 16:09
@Patrik-Stas Patrik-Stas requested a review from mirgee September 21, 2020 07:29
@Patrik-Stas Patrik-Stas force-pushed the feature/vcx-init-split branch 3 times, most recently from 00e0e31 to caafd88 Compare September 22, 2020 04:52
mirgee
mirgee previously approved these changes Sep 22, 2020
@Patrik-Stas Patrik-Stas force-pushed the feature/vcx-init-split branch 3 times, most recently from 91517e0 to b6f6b61 Compare September 23, 2020 10:32
…sion

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the feature/vcx-init-split branch from 2fa3637 to bac255a Compare September 24, 2020 11:19
@mirgee mirgee merged commit ffff156 into master Sep 24, 2020
@mirgee mirgee deleted the feature/vcx-init-split branch September 24, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants