Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tails variables in prover code #901

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jul 18, 2023

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@349d82e). Click here to learn what that means.
The diff coverage is 21.05%.

❗ Current head 3e84c41 differs from pull request most recent head fb1fecc. Consider uploading reports for the commit fb1fecc to get more accurate results

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage        ?   43.37%           
=======================================
  Files           ?      438           
  Lines           ?    34777           
  Branches        ?     7589           
=======================================
  Hits            ?    15085           
  Misses          ?    15231           
  Partials        ?     4461           
Flag Coverage Δ
unittests-aries-vcx 43.37% <21.05%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/proof_presentation/types.rs 46.80% <ø> (ø)
aries_vcx/tests/utils/scenarios.rs 83.87% <0.00%> (ø)
...es_vcx/src/common/proofs/prover/prover_internal.rs 27.27% <22.22%> (ø)

Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, has been a smell for me for awhile

@gmulhearn
Copy link
Contributor

out of sync with main, but LGTM

@Patrik-Stas Patrik-Stas merged commit def6295 into main Jul 20, 2023
@Patrik-Stas Patrik-Stas deleted the refactor/prover-tails-args branch July 20, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants