Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiling the workspace with --tests --all-features #890

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jun 30, 2023

A hotfix to enable compiling the workspace with --tests --all-features.

It is recommended that

[...] features should be additive. That is, enabling a feature should not disable functionality, and it should usually be safe to enable any combination of features. [...]

meaning the code should compile with all features enabled as well.

(Selfish reason is that I am using these cargo options in the rust-analyzer settings globally to enable code completion and error / warnings hints in any Rust project in all code, including code compiled conditionally using features and all tests. If the workspace stops compiling before it reaches the code I am working on, I get no error hints.)

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added the hotfix High priority fixes of unexpected issues label Jun 30, 2023
@mirgee mirgee requested a review from Patrik-Stas June 30, 2023 07:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #890 (c9a0c53) into main (c1180a7) will decrease coverage by 3.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   49.90%   46.24%   -3.67%     
==========================================
  Files         432      432              
  Lines       35058    35058              
  Branches     7617     7617              
==========================================
- Hits        17497    16213    -1284     
- Misses      12284    13903    +1619     
+ Partials     5277     4942     -335     
Flag Coverage Δ
unittests-aries-vcx 46.23% <ø> (-3.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvdrtools/src/lib.rs 91.07% <ø> (ø)

... and 55 files with indirect coverage changes

@Patrik-Stas Patrik-Stas merged commit 21dfe9b into main Jul 3, 2023
@Patrik-Stas Patrik-Stas deleted the hotfix/compile-all-features branch July 3, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix High priority fixes of unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants