Implementation of did:peer:2 DID method #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cb1eae to
2de180f
Compare
|
FYI @Jsyro . |
91dd534 to
71f3055
Compare
bc73803 to
bc5fa24
Compare
ac1d7dc to
636d362
Compare
|
FYI — We just did a quick clarification to the DID Peer Spec. to clarify that the padding characters of the Base64URL encoding of the service item MUST have the padding characters removed. The padding characters (“=“) are not permitted in a DID, per the peer DID spec. |
4936275 to
3c9d5a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 49.90% 8.43% -41.47%
==========================================
Files 432 410 -22
Lines 35058 33546 -1512
Branches 7613 7218 -395
==========================================
- Hits 17496 2830 -14666
- Misses 12285 29915 +17630
+ Partials 5277 801 -4476
Flags with carried forward coverage won't be shown. Click here to find out more. |
Patrik-Stas
requested changes
Jun 23, 2023
|
|
||
| impl Key { | ||
| pub fn new(key: Vec<u8>, key_type: SupportedKeyType) -> Result<Self, DidPeerError> { | ||
| // If the key is a multibase key coming from a verification method, for some reason it is also |
There was a problem hiding this comment.
todo for myself: review this
There was a problem hiding this comment.
This is a point of confusion for me as well, so it will be good to have another pair of eyes (with a brain attached) taking a look at it. 👍
bobozaur
suggested changes
Jun 23, 2023
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
previously approved these changes
Jun 26, 2023
bobozaur
previously approved these changes
Jun 26, 2023
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of did:peer method 2:
The main non-functional requirement is maximal interoperability with the already existing implementations in other Aries frameworks.