-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/testing #880
Merged
Merged
Refactor/testing #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 49.54% 46.91% -2.64%
==========================================
Files 436 438 +2
Lines 35163 34826 -337
Branches 7659 7578 -81
==========================================
- Hits 17423 16340 -1083
- Misses 12450 13690 +1240
+ Partials 5290 4796 -494
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
force-pushed
the
refactor/testing
branch
from
June 10, 2023 08:59
89e736c
to
24d6a9a
Compare
bobozaur
force-pushed
the
change/remove-profiles
branch
from
June 13, 2023 14:57
02ff8d5
to
5d213d5
Compare
Patrik-Stas
force-pushed
the
refactor/testing
branch
2 times, most recently
from
June 16, 2023 10:44
8a4fa46
to
0190cf1
Compare
Patrik-Stas
force-pushed
the
refactor/testing
branch
from
June 25, 2023 18:18
bd84432
to
fc12b56
Compare
Patrik-Stas
force-pushed
the
refactor/testing
branch
6 times, most recently
from
June 27, 2023 17:56
371d3ac
to
dbf4014
Compare
Patrik-Stas
force-pushed
the
refactor/testing
branch
3 times, most recently
from
June 28, 2023 07:59
18d1522
to
402bdd9
Compare
bobozaur
previously approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
refactor/testing
branch
from
July 4, 2023 11:58
2b639f4
to
568c796
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
bobozaur
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aries-vcx Alice/Faber testing
Implement
create_faber
similarly like we hadcreate_alice
, which construct the test agent with regard to to feature flags. This significantly increases coverage of issuer/verifier tests running modular libs profile.Use
SetupProfile
as basis to build out components for Faber/Alice (create_faber
/create_alice
) in integration tests in favor of logic duplicated insetup_modular_profile
,setup_indy_wallet
,setup_indy_wallet
(now deleted). This again significantly increases coverage for different profile feature flagsLibvcx
Rework global storage/Profile handling in
libvcx_core
. Remove notion of "handles" from libvcx global state, instead is replaced with dealing with individual components (base wallet, anoncreds etc.). This opens up door for swapping different implementation on libvcx level, such as using modural libs componentsRemove testing feature infra from libvcx, run libvcx unit tests in CI (this was dropped somewhere along the way)
Decrease usage of global "settings" variables used in libvcx tests
Various smaller changes
SetupPool
toSetupPoolDirectory
and change behaviour, such that it doesn't connect to pool, only prepares path to store temporary pool genesis file. Previously in some tests, we been doing extra unused connection to pool.TestSetupCreateWallet
and the single libvcx (deprecated component) test utilizing it 'test_vcx_init_called_twice_passes_after_shutdown' - wallet/pool re-initialization is still indirectly covered by NodeJS integration testsstate_vcx_shutdown
behaviour - ignoredelete
argument, which deletes wallet and pool. This was unused and is practically rather dangerous than useful.