Fix 877: Connection Requests with empty DIDDoc pubkey controller

[gmulhearn-anonyome]

Fixes #877 , pls see ticket for more info.

i can write a test if desired, but I've tested this fix against ACA-py 0.8.1 and confirmed the problem is resolved. this bug was likely just an oversight, as all other AriesDidDoc constructions (exception this one) involved setting the id first.

[codecov-commenter]

Codecov Report

Merging #878 (b7bd4c3) into main (8b1eb3e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   48.89%   48.88%   -0.01%     
==========================================
  Files         432      432              
  Lines       34324    34324              
  Branches     7609     7609              
==========================================
- Hits        16782    16781       -1     
- Misses      12266    12267       +1     
  Partials     5276     5276              

Flag	Coverage Δ
unittests-aries-vcx	48.85% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aries_vcx/src/protocols/connection/invitee/mod.rs	69.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

[Patrik-Stas]

Thanks for investigation and fix!

I find it pretty bad that the order of those calls matter within the legacy diddoc crate, but not worthy attention as it's on track to be deprecated.

Lgtm ✅