-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject only required components, not entire profiles #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
3 times, most recently
from
June 6, 2023 14:02
edbc042
to
0bf1f5d
Compare
Patrik-Stas
force-pushed
the
refactor/do-not-consume-profile
branch
from
June 6, 2023 14:14
8f2f01e
to
a525a5b
Compare
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
from
June 6, 2023 14:33
0bf1f5d
to
84cbb0f
Compare
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
==========================================
+ Coverage 48.88% 49.90% +1.02%
==========================================
Files 432 432
Lines 34337 35058 +721
Branches 7612 7608 -4
==========================================
+ Hits 16784 17497 +713
- Misses 12277 12284 +7
- Partials 5276 5277 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
force-pushed
the
refactor/do-not-consume-profile
branch
2 times, most recently
from
June 7, 2023 09:38
1e13e27
to
81f1846
Compare
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
from
June 7, 2023 09:58
84cbb0f
to
902638d
Compare
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
from
June 7, 2023 11:27
902638d
to
68fee40
Compare
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
3 times, most recently
from
June 7, 2023 14:51
878d741
to
166c8fd
Compare
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
3 times, most recently
from
June 8, 2023 15:27
7a653ac
to
7461831
Compare
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
from
June 8, 2023 16:40
7461831
to
b0ce032
Compare
mirgee
previously approved these changes
Jun 9, 2023
Patrik-Stas
force-pushed
the
change/remove-profiles
branch
from
June 9, 2023 14:29
a89cc93
to
d04439d
Compare
@gmulhearn if this is fine with you, feel free to merge Big delta but trivial changes mostly |
bobozaur
approved these changes
Jun 13, 2023
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
bobozaur
force-pushed
the
change/remove-profiles
branch
from
June 13, 2023 14:57
02ff8d5
to
5d213d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile
abstraction has been introduced to enable smooth transition fromvdrtools
to modular libs (credx/anoncreds, indy-vdr, askar).Profile
represents basket of trait objects to perform variety of operations.Previously
Profile
was widely present inaries-vcx
codebase as a convenient way to access various lower-level APIs. However this was at the price of:aries-vcx
consumers to build entire "Profile", even though the APIs they've consequently used only used limited number of profile's components (eg, you don't need access to ledger in order to build credential proposal, for example)aries-vcx
to store building blocks in particular way (Profiles) - but consuming applications might want to store/handle things differntly.This PR modifies
aries-vcx
andaries-vcx-core
method signatures to be unaware ofProfile
abstraction - the APIs now only speak in terms of individual components such asdyn BaseAnoncreds
,dyn AnoncredsLedgerRead
- so the APIs ask only for what they really need.Additional extra benefit is that it's now much easier to spot fishy stuff, like "oh, this method requires access to ledger? That's weird, why is that???"