Minor DDO service builder improvement #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1ee705 to
886d6d1
Compare
Codecov Report
@@ Coverage Diff @@
## main #868 +/- ##
=======================================
Coverage 48.88% 48.88%
=======================================
Files 432 432
Lines 34324 34324
Branches 7609 7609
=======================================
Hits 16781 16781
+ Misses 12267 12266 -1
- Partials 5276 5277 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
886d6d1 to
d5ffa6c
Compare
6c610e4 to
731a9af
Compare
d5ffa6c to
d0279a6
Compare
731a9af to
7678382
Compare
d0279a6 to
19d0d81
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
19d0d81 to
4107359
Compare
Patrik-Stas
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the typestate pattern to statically ensure service type was set.