Make DidDocument's service generic over method-specific fields #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 8.68% 48.90% +40.22%
==========================================
Files 410 432 +22
Lines 32812 34324 +1512
Branches 7211 7609 +398
==========================================
+ Hits 2849 16787 +13938
+ Misses 29162 12264 -16898
- Partials 801 5273 +4472
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6c610e4 to
731a9af
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
731a9af to
7678382
Compare
Patrik-Stas
requested changes
Jun 7, 2023
Patrik-Stas
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was decided that
DidDocumentintegration will be postponed, this PR cherry-picks those changes made in #864 which are isolated to the new crates and thus can be merged independently from theDidDocumentintegration.