Split IndyVdrLedger and IndySdkLedger

[mirgee]

Splits

• IndyVdrLedger -> IndyVdrLedgerRead & IndyVdrLedgerWrite, and
• IndySdkLedger -> IndySdkLedgerRead & IndySdkLedgerWrite

This allows each implementation to use only what it needs (e.g. IndyVdrLedgerRead variant doesn't need RequestSigner, IndyVdrLedgerWrite doesn't need ResponseCacher and ResponseParser). Moreover, since both are initialized separately, a IndyLedgerRead implementation can be used to initialize a IndyLedgerWrite implementation.

[codecov-commenter]

Codecov Report

Merging #862 (497df30) into main (9f2e922) will decrease coverage by 0.69%.
The diff coverage is 37.27%.

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   48.88%   48.20%   -0.69%     
==========================================
  Files         428      428              
  Lines       34134    34103      -31     
  Branches     7517     7502      -15     
==========================================
- Hits        16687    16439     -248     
- Misses      12294    12549     +255     
+ Partials     5153     5115      -38     

Flag	Coverage Δ
unittests-aries-vcx	48.17% <37.27%> (-0.68%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ries_vcx/src/utils/mockdata/profile/mock_ledger.rs	29.33% <0.00%> (ø)
aries_vcx_core/src/ledger/indy_vdr_ledger.rs	30.43% <24.69%> (-0.31%)	⬇️
aries_vcx_core/src/ledger/indy_ledger.rs	63.77% <44.44%> (-4.26%)	⬇️
aries_vcx/src/core/profile/modular_libs_profile.rs	82.00% <100.00%> (+1.14%)	⬆️
aries_vcx/src/core/profile/vdrtools_profile.rs	74.28% <100.00%> (-8.07%)	⬇️

... and 29 files with indirect coverage changes

[Patrik-Stas]

perhaps can be removed now?

[mirgee]

Unfortunately get_ledger_txn still needs WalletHandle to sign the request if submitter_did is passed in - but perhaps we can omit this argument and not sign the request as with the other getters. However, I don't think there is much worth in optimizing IndySdkLedger as it is soon-to-be-deleted.

[bobozaur]

Maybe not worth it doing it here, but how about taking a generic implementing BaseWallet along with the submitter_did? Something like Option(&str, &T) where T: BaseWallet. Shouldn't that remove the need to store the wallet handle while also making it easier to work with that scenario since the arguments are either provided together or not at all?

[bobozaur]

I merely have an observation. Otherwise LGTM.