Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In memory response cacher #855

Merged
merged 10 commits into from
May 22, 2023
Merged

In memory response cacher #855

merged 10 commits into from
May 22, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented May 18, 2023 •
edited
Loading

Implements a simple naive in-memory ledger response cacher and uses it in IndyVdrLedger.

@mirgee
Ledger response parser
3c1f88b 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the feature/response-cacher branch from bffae45 to e5f8754 Compare May 18, 2023 11:56
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023 •
edited
Loading

Codecov Report

Merging #855 (b8dd068) into main (dc69b63) will decrease coverage by 40.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #855       +/-   ##
==========================================
- Coverage   49.06%   8.69%   -40.37%     
==========================================
  Files         424     408       -16     
  Lines       34084   32911     -1173     
  Branches     7529    7215      -314     
==========================================
- Hits        16722    2861    -13861     
- Misses      12167   29239    +17072     
+ Partials     5195     811     -4384
Flag Coverage Δ
unittests-aries-vcx 8.69% <ø> (-40.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/utils/devsetup.rs 30.93% <ø> (-36.79%) ⬇️

... and 314 files with indirect coverage changes

@mirgee mirgee force-pushed the feature/response-cacher branch from e5f8754 to cffd9c2 Compare May 18, 2023 14:09
@mirgee
Address CR
07e2c8e 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/indy-vdr-ledger-remove-base-wallet branch from f930306 to 923cfa4 Compare May 19, 2023 06:53
@mirgee mirgee force-pushed the feature/response-cacher branch 3 times, most recently from 681f198 to 2371cfe Compare May 19, 2023 08:49
mirgee added 5 commits May 19, 2023 12:11
@mirgee
Implement TryFrom for both typed reply versions
b1f1a0b 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee
Use array instead of vec for reply
dcd220f 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee
Implement transaction endorsing in IndyVdrLedger and enable test
fb758cd 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee
Address CR
e7e8245 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee
Remove dependency on BaseWallet from IndyVdrLedger
a63c376 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/indy-vdr-ledger-remove-base-wallet branch from 923cfa4 to a63c376 Compare May 19, 2023 10:59
@mirgee mirgee force-pushed the feature/response-cacher branch 5 times, most recently from 02b4dd1 to 671eb84 Compare May 19, 2023 11:51
@mirgee mirgee marked this pull request as ready for review May 19, 2023 12:21
@mirgee mirgee force-pushed the feature/response-cacher branch from 671eb84 to 0f3739e Compare May 19, 2023 12:25
@mirgee
WIP: In memory response cacher
7f6754b 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the feature/response-cacher branch from 0f3739e to 7f6754b Compare May 19, 2023 12:27
Patrik-Stas
Patrik-Stas requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

aries_vcx_core/src/ledger/indy_vdr_ledger.rs Outdated Show resolved Hide resolved
aries_vcx_core/src/ledger/response_cacher/in_memory/mod.rs Outdated Show resolved Hide resolved
aries_vcx_core/src/ledger/response_cacher/in_memory/mod.rs Outdated Show resolved Hide resolved
aries_vcx_core/src/ledger/response_cacher/in_memory/mod.rs Outdated Show resolved Hide resolved
aries_vcx_core/src/ledger/response_cacher/in_memory/mod.rs Outdated Show resolved Hide resolved
aries_vcx_core/src/ledger/response_cacher/in_memory/mod.rs Show resolved Hide resolved
@mirgee mirgee requested review from Patrik-Stas May 19, 2023 14:00
@mirgee
Address code review
14f7767 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the feature/response-cacher branch from 32afbcd to 14f7767 Compare May 19, 2023 14:14
Base automatically changed from refactor/indy-vdr-ledger-remove-base-wallet to main May 19, 2023 15:25
@mirgee
Merge branch 'main' into feature/response-cacher
b8dd068 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>

# Conflicts:
#	aries_vcx/src/core/profile/modular_libs_profile.rs
#	aries_vcx/src/core/profile/vdr_proxy_profile.rs
#	aries_vcx_core/Cargo.toml
#	aries_vcx_core/src/ledger/indy_vdr_ledger.rs
#	did_resolver_sov/src/reader/vdr_reader.rs
@Patrik-Stas Patrik-Stas requested review from gmulhearn and bobozaur May 19, 2023 16:10
bobozaur
bobozaur approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@bobozaur bobozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a quick look.

@Patrik-Stas Patrik-Stas merged commit 516cd3a into main May 22, 2023
@Patrik-Stas Patrik-Stas deleted the feature/response-cacher branch May 22, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobozaur bobozaur bobozaur approved these changes

@Patrik-Stas Patrik-Stas Patrik-Stas approved these changes

@gmulhearn gmulhearn Awaiting requested review from gmulhearn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirgee @codecov-commenter @Patrik-Stas @bobozaur