-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on BaseWallet from IndyVdrLedger #853
Remove dependency on BaseWallet from IndyVdrLedger #853
Conversation
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
880e2d0
to
f930306
Compare
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 49.05% 49.06% +0.01%
==========================================
Files 423 424 +1
Lines 34077 34084 +7
Branches 7528 7529 +1
==========================================
+ Hits 16717 16724 +7
- Misses 12166 12167 +1
+ Partials 5194 5193 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
{ | ||
pub wallet: Arc<dyn BaseWallet>, | ||
pub request_signer: Arc<U>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mirgee perhaps this can be cherry picked out out of from top of |
@mirgee That would not be as simple and straightforward as it might perhaps seem. Of course the conflicts can be fixed, but I don't see a reason to rush this in. |
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
56640e6
to
43a5b89
Compare
f930306
to
923cfa4
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
43a5b89
to
e7e8245
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
923cfa4
to
a63c376
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> # Conflicts: # aries_vcx/src/core/profile/modular_libs_profile.rs # aries_vcx/src/core/profile/vdr_proxy_profile.rs # aries_vcx_core/src/ledger/indy_vdr_ledger.rs # did_resolver_sov/src/reader/vdr_reader.rs
Remove dependency on
BaseWallet
fromIndyVdrLedger
in favor of injecting a singing-specific trait implementation.