-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ledger response parser #851
Conversation
2d4a86c
to
a48207f
Compare
a48207f
to
a852696
Compare
72d824a
to
49281f7
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
49281f7
to
3c1f88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed partially, will continue tonight/tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments but nothing big, this is really great improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think there are some improvements that can be made, especially regarding parse_message
.
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 48.95% 48.79% -0.16%
==========================================
Files 415 423 +8
Lines 33784 34027 +243
Branches 7493 7510 +17
==========================================
+ Hits 16539 16605 +66
- Misses 12107 12285 +178
+ Partials 5138 5137 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the mistake on the suggestion. This adapts your changes further to get everything a bit more streamlined. Thanks for considering my suggestions nonetheless!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the last suggestion for the Message<T>
, and also wondering about this Vec
in ReplyV1
. I'm curious of what your thoughts are on this.
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Extracts ledger response parsing capability into the
indy-ledger-response-parser
crate whichindy-data-types
(reexported byindy-vdr
) andlibvdrtools
) for ledger responses.This crate is further integrated into
IndyVdrLedger
implementation to replace the current provisional constructions.