Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic implementation of did:web resolver #828

Merged
merged 1 commit into from
May 10, 2023
Merged

Basic implementation of did:web resolver #828

merged 1 commit into from
May 10, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented May 3, 2023 •
edited
Loading

Implementation of the did:web DID method resolver.

https://w3c-ccg.github.io/did-method-web

@mirgee mirgee added the skip-ci label May 3, 2023
@mirgee mirgee force-pushed the feature/did-web-resolver branch from d70a7b5 to 1e5e171 Compare May 3, 2023 14:49
@mirgee mirgee requested a review from Patrik-Stas May 3, 2023 14:50
@mirgee mirgee force-pushed the feature/did-web-resolver branch from 1e5e171 to f641e54 Compare May 4, 2023 10:06
@mirgee mirgee force-pushed the feature/did-resolver branch from 11ac111 to c502bf9 Compare May 4, 2023 10:27
@mirgee mirgee force-pushed the feature/did-web-resolver branch 2 times, most recently from 9fef546 to 3a5bbad Compare May 4, 2023 11:02
Patrik-Stas
Patrik-Stas previously approved these changes May 8, 2023
View reviewed changes
@Patrik-Stas Patrik-Stas requested review from gmulhearn and bobozaur May 8, 2023 09:37
Base automatically changed from feature/did-resolver to main May 9, 2023 14:08
@mirgee
Basic implementation of did:web resolver
bd21942 
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the feature/did-web-resolver branch from 4724260 to bd21942 Compare May 9, 2023 14:21
@mirgee mirgee marked this pull request as ready for review May 9, 2023 14:24
bobozaur
bobozaur approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@bobozaur bobozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patrik-Stas Patrik-Stas merged commit 244b8b3 into main May 10, 2023
@Patrik-Stas Patrik-Stas deleted the feature/did-web-resolver branch May 10, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobozaur bobozaur bobozaur approved these changes

@Patrik-Stas Patrik-Stas Patrik-Stas left review comments

@gmulhearn gmulhearn Awaiting requested review from gmulhearn

Assignees
No one assigned
Labels
skip-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirgee @Patrik-Stas @bobozaur