move common stuff from the messages crate to shared_vcx

[swaptr]

Fixes #821

[Patrik-Stas]

hi @swaptr note that some of the commits in the PR are missing DCO signoff

[swaptr]

Yes, I am fixing that.

[bobozaur]

Just a small thing, and it is my fault for not mentioning this in the issue (I'll add it now).
The NoDecorators name was more contextual to the messages crate.

The type is really more of a Nothing type from a serde standpoint (at least serde_json, which is what we care about), meaning that it's deserialized from thin air and serialized into no additional data (which is what we want in the way we use it as a dummy decorator placeholder).

So I suggest to rename it, maybe something like SerdeIgnored and perhaps add an alias in the messages crate to maintain the NoDecorators naming as it's clearer in that context what it is for.

[swaptr]

Done. I added some comments, lmk if you feel its unnecessary or verbose.

[bobozaur]

Done. I added some comments, lmk if you feel its unnecessary or verbose.

Not at all! Comments are my spirit animal (??? 😆 ).

[codecov-commenter]

Codecov Report

Merging #826 (3c71eca) into main (81e1487) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #826   +/-   ##
=======================================
  Coverage   45.16%   45.17%           
=======================================
  Files         408      409    +1     
  Lines       33468    33468           
  Branches     7437     7439    +2     
=======================================
+ Hits        15117    15119    +2     
+ Misses      13583    13580    -3     
- Partials     4768     4769    +1     

Flag	Coverage Δ
unittests-aries-vcx	45.17% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
messages/src/decorators/localization.rs	0.00% <ø> (ø)
messages/src/lib.rs	74.19% <ø> (ø)
messages/src/misc/utils.rs	70.58% <ø> (+2.16%)	⬆️
...g_fields/protocols/connection/invitation/public.rs	57.14% <ø> (ø)
...es/src/msg_fields/protocols/connection/response.rs	68.42% <ø> (ø)
...ages/src/msg_fields/protocols/cred_issuance/mod.rs	67.85% <ø> (ø)
...ages/src/msg_fields/protocols/out_of_band/reuse.rs	66.66% <ø> (ø)
...msg_fields/protocols/out_of_band/reuse_accepted.rs	66.66% <ø> (ø)
.../src/msg_fields/protocols/present_proof/propose.rs	48.43% <ø> (ø)
...essages/src/msg_fields/protocols/report_problem.rs	30.26% <ø> (ø)
... and 5 more

... and 2 files with indirect coverage changes