-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump time to 0.3.20
#800
Bump time to 0.3.20
#800
Conversation
Thank you @swaptr! Let's wait for CI |
ba1cded
to
fd36ee5
Compare
Thank you @Patrik-Stas for reviewing the PR. I think CI should work now. Also idk for some reason I am having trouble with signing commits, hence I have to squash and force push as a workaround. Until I fix this, I hope this is not an issue. |
Hi @swaptr seems like you've figured out the DCO. There's a failure in CI - test can't yet compile. Have a look please, seems like some additional tweak are required. You can easily verify the compilation locally
and also
running these 2 command from root directory of the repo. Thank you! |
Codecov Report
@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 48.95% 48.97% +0.01%
==========================================
Files 410 410
Lines 33458 33462 +4
Branches 7426 7425 -1
==========================================
+ Hits 16380 16388 +8
+ Misses 11978 11977 -1
+ Partials 5100 5097 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hi @swaptr are you willing to further drive this PR to completion? It seems there's still some work outstanding
Additionally note we are now in bit of a freeze mode for couple day, waiting for #787 to be completed. |
80a9ecd
to
fdf316c
Compare
I am sorry for the delayed work on this PR. Thank you for your patience, although I did fix test compilations but as per your instructions I will update this PR once again after the freeze is over. |
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
@Patrik-Stas, I have fixed majority of the issues with this PR, but somehow the CI is still failing. I am out of ideas to fix this, can you look into this? |
hi @swaptr it's was a false positive failure. Not your fault, we'll have to tweak our CI to prevent this from happening on "from-fork" PRs |
Merged now :-) Thank you for contribution! |
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
This PR addresses the breaking changes in the
time
crate dependency.This PR aims to upgrade
time
to0.3.20
.Fixes #795