Separate core into a standalone crate #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> # Conflicts: # aries_vcx/Cargo.toml # aries_vcx/src/common/primitives/credential_definition.rs # aries_vcx/src/errors/mod.rs # aries_vcx/src/lib.rs # aries_vcx/src/utils/mockdata/profile/mock_anoncreds.rs # aries_vcx/src/utils/mockdata/profile/mock_ledger.rs # aries_vcx/src/utils/mockdata/profile/mock_wallet.rs # aries_vcx/src/utils/mod.rs # aries_vcx_core/src/indy/credentials/issuer/mod.rs # aries_vcx_core/src/ledger/indy_ledger.rs # libvcx_core/src/api_vcx/api_handle/issuer_credential.rs
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
bed3d69 to
e0b9e3a
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> # Conflicts: # Cargo.lock # aries_vcx/Cargo.toml # libvdrtools/Cargo.toml
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
1364873 to
944236a
Compare
bobozaur
added a commit
that referenced
this pull request
Apr 13, 2023
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
gmulhearn
previously approved these changes
Apr 13, 2023
gmulhearn
reviewed
Apr 13, 2023
|
@gmulhearn good catch! Rerunning |
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
a699292
Codecov Report
@@ Coverage Diff @@
## main #798 +/- ##
===========================================
- Coverage 54.18% 29.13% -25.05%
===========================================
Files 381 390 +9
Lines 36787 30694 -6093
Branches 8300 6380 -1920
===========================================
- Hits 19932 8944 -10988
- Misses 10702 18993 +8291
+ Partials 6153 2757 -3396
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 163 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
bc966c6 to
b99839d
Compare
Patrik-Stas
approved these changes
Apr 13, 2023
|
Running full CI revealed few issues (compile and CI issues), go it fixed, not a big changes so I am merging per previous approvals. |
bobozaur
added a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
bobozaur
added a commit
that referenced
this pull request
Apr 26, 2023
* Separate plugins into a crate Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use BaseAnoncreds from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use BaseWallet from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use IndyWallet from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use IndyAnoncreds, CredxAnoncreds from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use BaseLedger from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use IndyLedger, IndyVdrLedger from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Prune indy aries_vcx module Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Remove holder and wallet from indy module Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Remove remainder of indy dir from aries_vcx Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * aries_vcx, aries_vcx core builds with all features Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * libvcx_core + tests compile Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Export newtype wallet handle from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * libvcx_core + tests compile Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Decide to reexport aries_vcx_core from aries_vcx Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Workspace compiles Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * workspace compiles, no reexports Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Replaced messages in mediated connection handler Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * All handlers use new messages Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in Connection invitee state machine Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in Connection state machine Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in Holder state machine Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced more of the old messages Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages to new ones in MediatedConnection Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced messages in Prover Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced messages in Verifier Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Finished messages replacement Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Added more usage for AttachmentId and retrofitted deserialization of mediated_connection states Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Integrated new messages into aries-vcx-agent Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Workspace compiling (except for uniffi wrapper due to lack of Url type definition in the UDL file) Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed https links Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed dummy invitation Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Updated request building Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Restored index.js and index.d.ts from main Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed oob to_string() impls Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed mediated connection thread ID Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed forward message wrapping Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced Vec<u8> with Value in Forward msg for backwards compatibility Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed deserialization errors when the deserializer owned the data Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed response building in MediatedConnection Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * More fixes to Response building Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * DID doc state fixes Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Finally fixed Response building Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Added early return and removed ? in Protocol parsing Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Extended TS HandshakeProtocol enum for backwards compatibility Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed MimeType and renamed Attribute to PresentationAttr Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Corrected AttachmentId handling Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Corrected impl of connection signature to be its own message type Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Added SignatureTypeV1 to ProtocolRegistry Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * With teary eyes added #[serde(default)] to PleaseAck decorator for backwards compatibility Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Corrected OOB invitation impl Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced Vec<u8> with String in Base64 attachment Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed attachment handling Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Further fixed on attachment handling Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed OOB invitation attachment serialization Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed con unit tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed some thread_id issues Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Rebased from main Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed uniffi by accepting AriesDidDoc as String Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Restored messages/test_utils in aries_vcx Cargo.toml Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced more Strings with Urls Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Agency_client tests working Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * DidDoc crate tests fixed Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Libvcx_core tests compile Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Rebased from #798 Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * aries_vcx integration tests compile Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flags from shared_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flags from aries_vcx_core Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flags from diddoc Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Post feature flag removal in aries-vcx fix Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * More fixes on aries_vcx tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Aries-vcx tests work (sometimes) Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Adapted CI to removed feature flags from aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Rebased from main Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * libvcx_core tests all run Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flag traces from aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Parsing URLs in node wrappers as URLs and not strings Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed CI workflow Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * CI fixes and ignoring tails in gitignore Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed feature flags mismatch for CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * More CI fixes Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fix for wrapper tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Updated rust toolchain version in all places Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Bumped vcxagency docker container version in CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed connection_send_generic_message in napi wrapper Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fix issue with *_proposal_* tests Signed-off-by: Patrik Stas <patrik.stas@absa.africa> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Tentative fix for the iOS CI builds Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Adding package-lock.json back Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed unnecessary vdrtools handle wrappers Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Test fixes after handle wrapper removal Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Attempt to fix linking issues in iOS CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Trying to trigger CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Dummy commit to make CI publish a different napi package version Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Dummy commit to trigger CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Another dummy commit to trigger CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Uncommented test Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Adjusted tests as per PR comments Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed obsolete dependency_flag check and default_features issue in aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Hopefully fixing the mess we call tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> --------- Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> Signed-off-by: Patrik Stas <patrik.stas@absa.africa> Co-authored-by: Miroslav Kovar <miroslav.kovar@absa.africa> Co-authored-by: Patrik Stas <patrik.stas@absa.africa>
tech-bash
pushed a commit
to tech-bash/aries-vcx
that referenced
this pull request
Apr 30, 2023
* Separate plugins into a crate Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use BaseAnoncreds from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use BaseWallet from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use IndyWallet from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use IndyAnoncreds, CredxAnoncreds from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use BaseLedger from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Use IndyLedger, IndyVdrLedger from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Prune indy aries_vcx module Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Remove holder and wallet from indy module Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Remove remainder of indy dir from aries_vcx Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * aries_vcx, aries_vcx core builds with all features Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * libvcx_core + tests compile Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Export newtype wallet handle from aries_vcx_core Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * libvcx_core + tests compile Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Decide to reexport aries_vcx_core from aries_vcx Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Workspace compiles Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * workspace compiles, no reexports Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> * Replaced messages in mediated connection handler Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * All handlers use new messages Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in Connection invitee state machine Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in Connection state machine Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in Holder state machine Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced more of the old messages Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages to new ones in MediatedConnection Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced messages in Prover Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced messages in Verifier Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced old messages with new ones in aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Finished messages replacement Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Added more usage for AttachmentId and retrofitted deserialization of mediated_connection states Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Integrated new messages into aries-vcx-agent Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Workspace compiling (except for uniffi wrapper due to lack of Url type definition in the UDL file) Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed https links Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed dummy invitation Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Updated request building Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Restored index.js and index.d.ts from main Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed oob to_string() impls Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed mediated connection thread ID Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed forward message wrapping Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced Vec<u8> with Value in Forward msg for backwards compatibility Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed deserialization errors when the deserializer owned the data Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed response building in MediatedConnection Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * More fixes to Response building Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * DID doc state fixes Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Finally fixed Response building Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Added early return and removed ? in Protocol parsing Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Extended TS HandshakeProtocol enum for backwards compatibility Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed MimeType and renamed Attribute to PresentationAttr Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Corrected AttachmentId handling Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Corrected impl of connection signature to be its own message type Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Added SignatureTypeV1 to ProtocolRegistry Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * With teary eyes added #[serde(default)] to PleaseAck decorator for backwards compatibility Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Corrected OOB invitation impl Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced Vec<u8> with String in Base64 attachment Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed attachment handling Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Further fixed on attachment handling Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed OOB invitation attachment serialization Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed con unit tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed some thread_id issues Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Rebased from main Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed uniffi by accepting AriesDidDoc as String Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Restored messages/test_utils in aries_vcx Cargo.toml Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Replaced more Strings with Urls Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Agency_client tests working Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * DidDoc crate tests fixed Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Libvcx_core tests compile Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Rebased from hyperledger#798 Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * aries_vcx integration tests compile Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flags from shared_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flags from aries_vcx_core Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flags from diddoc Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Post feature flag removal in aries-vcx fix Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * More fixes on aries_vcx tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Aries-vcx tests work (sometimes) Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Adapted CI to removed feature flags from aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Rebased from main Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * libvcx_core tests all run Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed feature flag traces from aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Parsing URLs in node wrappers as URLs and not strings Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed CI workflow Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * CI fixes and ignoring tails in gitignore Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed feature flags mismatch for CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * More CI fixes Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fix for wrapper tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Updated rust toolchain version in all places Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Bumped vcxagency docker container version in CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed connection_send_generic_message in napi wrapper Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fix issue with *_proposal_* tests Signed-off-by: Patrik Stas <patrik.stas@absa.africa> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Tentative fix for the iOS CI builds Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Adding package-lock.json back Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Removed unnecessary vdrtools handle wrappers Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Test fixes after handle wrapper removal Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Attempt to fix linking issues in iOS CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Trying to trigger CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Dummy commit to make CI publish a different napi package version Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Dummy commit to trigger CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Another dummy commit to trigger CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Uncommented test Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Adjusted tests as per PR comments Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed obsolete dependency_flag check and default_features issue in aries_vcx Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Hopefully fixing the mess we call tests Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> --------- Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> Signed-off-by: Patrik Stas <patrik.stas@absa.africa> Co-authored-by: Miroslav Kovar <miroslav.kovar@absa.africa> Co-authored-by: Patrik Stas <patrik.stas@absa.africa>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocates
BaseLedger,BaseAnonCreds,BaseWallettrait definitions and their corresponding implementations (including theindymodule and relatedutils) into a distinct crate calledaries_vcx_core. As a result,aries-vcxnow depends onindy-vdr,indy-credx, andlibvdrtoolsindirectly through this new crate, which doesn't reexport any of them.The primary objective of this pull request is the separation of these components, and no additional efforts were made to enhance the codebase beyond this specific aim.