Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_revocation_id for IssuerCredential #793

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

Patrik-Stas
Copy link
Contributor

No description provided.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #793 (01d8ebf) into main (ba2b151) will decrease coverage by 24.49%.
The diff coverage is 0.00%.

❗ Current head 01d8ebf differs from pull request most recent head ff828e5. Consider uploading reports for the commit ff828e5 to get more accurate results

@@             Coverage Diff             @@
##             main     #793       +/-   ##
===========================================
- Coverage   54.20%   29.72%   -24.49%     
===========================================
  Files         381      379        -2     
  Lines       36852    30619     -6233     
  Branches     8307     6440     -1867     
===========================================
- Hits        19977     9101    -10876     
- Misses      10713    18707     +7994     
+ Partials     6162     2811     -3351     
Flag Coverage Δ
unittests-aries-vcx 29.72% <0.00%> (-24.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/issuance/issuer.rs 48.54% <0.00%> (-9.91%) ⬇️

... and 211 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@mirgee mirgee merged commit 2f45045 into main Apr 7, 2023
@mirgee mirgee deleted the feature/get_revocation_id branch April 7, 2023 04:17
Andy-Waine pushed a commit to Andy-Waine/aries-vcx that referenced this pull request Apr 13, 2023
* Add get_revocation_id for IssuerCredential

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>

* Fix typo

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>

* Fix JS wrapper method name

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>

---------

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Andy Waine <88730354+Andy-Waine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants