Vdrtools & Modular Libs as feature flags

[gmulhearn]

This PR moves vdrtools & modular dependencies (indy-credx & indy-vdr) under their own separate feature flags.

The idea is that consumers who do not want to use vdrtools dependencies (e.g. using modular deps or their even own deps instead), can override the default flag and use their own Profile. This way the consumer does not have to pull in the heavy-weight deps of libvdrtools. Likewise for modular_libs.

I've kept vdrtools as the default feature for aries_vcx, as it is most likely what is currently used the most. In the future we may think about changing this

It is also enforced, that when testing with test_utils, both vdrtools and modular_libs must be enabled.

Other Changes

• Had to move the LibIndyMocks structure out of indy. There is now a global statuscodemock for the same functionality, however in the long term, we should remove this
• renamed modular_dependencies to modular_libs_tests to better represent that it is just a testing feature flag.

[codecov-commenter]

Codecov Report

Merging #763 (6f489f6) into main (2f45045) will increase coverage by 7.26%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   46.93%   54.19%   +7.26%     
==========================================
  Files         381      381              
  Lines       32516    36850    +4334     
  Branches     7202     8307    +1105     
==========================================
+ Hits        15260    19972    +4712     
+ Misses      12491    10713    -1778     
- Partials     4765     6165    +1400     

Flag	Coverage Δ
unittests-aries-vcx	54.09% <50.00%> (+7.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...vcx/src/common/primitives/credential_definition.rs	49.74% <0.00%> (ø)
aries_vcx/src/indy/credentials/issuer/mod.rs	55.00% <0.00%> (ø)
aries_vcx/src/indy/utils/mod.rs	65.21% <ø> (+65.21%)	⬆️
aries_vcx/src/lib.rs	100.00% <ø> (+75.00%)	⬆️
aries_vcx/src/plugins/anoncreds/indy_anoncreds.rs	79.02% <ø> (ø)
aries_vcx/src/plugins/ledger/indy_ledger.rs	61.59% <ø> (ø)
...ries_vcx/src/utils/mockdata/profile/mock_wallet.rs	21.42% <0.00%> (+2.38%)	⬆️
aries_vcx/src/utils/mod.rs	60.00% <ø> (ø)
aries_vcx/tests/test_mysql_wallet.rs	100.00% <ø> (ø)
aries_vcx/src/global/settings.rs	69.56% <50.00%> (+1.14%)	⬆️
... and 5 more

... and 121 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gmulhearn]

@Patrik-Stas requested for review a bit early bcus i'm too impatient for wait for the pipeline! I will double check that it has passed later... but it should be good

[Patrik-Stas]

nice job with feature documentation

[Patrik-Stas]

@mirgee @bobozaur one of you please review and merge if you good with this

[Patrik-Stas]

@gmulhearn another great incremental step forward!

[bobozaur]

I'm okay with the changes considering the goal of the PR.

I think that in the future, though, we should strive towards refactoring all this test feature flag and mocks mess outside of aries-vcx (at least it's src).

Since aries-vcx does not depend on libvdrtoola, then it shouldn't even be used. We could maybe provide a vdrtools-based wallet et al in a separate crate that can be used by consumers.

[Patrik-Stas]

@bobozaur just some clarification

Since aries-vcx does not depend on libvdrtoola, then it shouldn't even be used.

aries-vcx does depend on libvdrtools, but the goal is to get rid of it - the feature flags are way to opt-in either vdrtools or indy-vdr+credex as implementation under the hood.

The testing feature flags are orthogonal to the changes in this pr, though I don't disagree there can be better way to test