Split libvcx in 2 crates, update diagrams #759
Conversation
Codecov Report
@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 54.40% 54.55% +0.15%
==========================================
Files 381 380 -1
Lines 36766 36673 -93
Branches 8092 8065 -27
==========================================
+ Hits 20002 20007 +5
+ Misses 10807 10714 -93
+ Partials 5957 5952 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3428a71 to
8401829
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
7fb7b6f to
cb0408d
Compare
| #[cfg(feature = "test_utils")] | ||
| pub mod tests_utils { | ||
| pub const BAD_CREDENTIAL_OFFER: &str = r#"{"version": "0.1","to_did": "LtMgSjtFcyPwenK9SHCyb8","from_did": "LtMgSjtFcyPwenK9SHCyb8","claim": {"account_num": ["8BEaoLf8TBmK4BUyX8WWnA"],"name_on_account": ["Alice"]},"schema_seq_no": 48,"issuer_did": "Pd4fnFtRBcMKRVC2go5w3j","claim_name": "Account Certificate","claim_id": "3675417066","msg_ref_id": "ymy5nth"}"#; | ||
| } | ||
|
|
There was a problem hiding this comment.
Probably not in the scope of this PR, as this spans across most the crates in the repository, but we should clear out these test-only stuff from the actual code.
Instead, we could provide something like common.rs (or common as a dir) in the integration tests folder where we can declare all the tests related stuff. Then mod common and use common::* would allow us to use all of these in integration tests without having to intertwine these things with the code.
Alternatively, if these need to be available for unit/doc tests, we could have separate crates for them directly. It would make the implementation crates cleaner and smaller.
There was a problem hiding this comment.
Yes, the test_utils under the /src are used for unit tests - though I am actually leaning to keep this as is, I am not strongly opinionated. I find it nice that the unit test utils for some domain are in respective files and right next to the tests which are using them the most.
We can discuss on other channels further
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Split
libvcxin 2 crates:libvcx_core- the handle layer oflibvcxextracted as separate cratelibvcx- this represents the same thing aslibvcxused to be. Built on top oflibvcx_core. This crate is now deprecated.