Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose multiple connection-related methods #741

Closed
wants to merge 5 commits into from

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Feb 1, 2023

  • Expose Ping, PingResponse and HandshakeReuseAccepted message builder
  • Expose credential and credential offer sending via nonmediated connection
  • Expose issuer and proof state updating via nonmediated connection
  • Expose existing nonmediated connection checking for out of band
  • Expose problem report processing for nonmediated connection

…onn.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added the wrappers label Feb 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #741 (6449e67) into main (66ee076) will decrease coverage by 0.03%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   54.73%   54.70%   -0.03%     
==========================================
  Files         363      363              
  Lines       37122    37144      +22     
  Branches     8089     8098       +9     
==========================================
+ Hits        20317    20321       +4     
- Misses      10832    10855      +23     
+ Partials     5973     5968       -5     
Flag Coverage Δ
unittests-aries-vcx 54.60% <29.41%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/connection/connection.rs 56.01% <0.00%> (-2.16%) ⬇️
aries_vcx/src/protocols/trustping/mod.rs 75.00% <0.00%> (-10.72%) ⬇️
aries_vcx/src/handlers/out_of_band/receiver.rs 37.96% <58.33%> (-1.09%) ⬇️
...vcx/src/handlers/connection/mediated_connection.rs 63.29% <100.00%> (+0.22%) ⬆️
.../src/protocols/connection/invitee/state_machine.rs 66.54% <100.00%> (+0.18%) ⬆️
libvdrtools/src/services/pool/pool.rs 48.05% <0.00%> (-0.19%) ⬇️
libvdrtools/src/services/pool/networker.rs 75.51% <0.00%> (+0.40%) ⬆️
libvdrtools/src/controllers/non_secrets.rs 47.80% <0.00%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@Patrik-Stas
Copy link
Contributor

Can we close in favor of #739 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants