Code

Refactor/typestate connections#739

Code

Merged

Patrik-Stas merged 66 commits intomainhyperledger/aries-vcx:mainfrom refactor/typestate_connectionshyperledger/aries-vcx:refactor/typestate_connectionsCopy head branch name to clipboardFeb 13, 2023

+4,561-1,809

Commits

Commits on Jan 25, 2023

• Added draft for typestate connection state machine

  Show description for d1096bf
  bobozaur

  committed
  d1096bf

  Copy full SHA for d1096bf

• Added dummy, not functional tests, as a mere representation of the transitions between states for the typestate Connection

  Show description for d76bf5e
  bobozaur

  committed
  d76bf5e

  Copy full SHA for d76bf5e

• Remove obsolete structs

  Show description for 598a7bc
  bobozaur

  committed
  598a7bc

  Copy full SHA for 598a7bc

• Remove dummy tests. Will properly reimplement them later

  Show description for 76f6c4f
  bobozaur

  committed
  76f6c4f

  Copy full SHA for 76f6c4f

• Removed transport type from type state Connection

  Show description for 0295e46
  bobozaur

  committed
  0295e46

  Copy full SHA for 0295e46

• Factored out build_con_request method

  Show description for 63f7d46
  bobozaur

  committed
  63f7d46

  Copy full SHA for 63f7d46

• Moved all typestate connection related code to a different module

  Show description for ee571df
  bobozaur

  committed
  ee571df

  Copy full SHA for ee571df

• Refactored inner methods and simplified them

  Show description for 8fff813
  bobozaur

  committed
  8fff813

  Copy full SHA for 8fff813

Commits on Jan 26, 2023

• Reverted changes on current code as the typestate_con is separated into a different module

  Show description for ad9a6fe
  bobozaur

  committed
  ad9a6fe

  Copy full SHA for ad9a6fe

• Added serde capabilities to typestate Connection

  Show description for fb1260a
  bobozaur

  committed
  fb1260a

  Copy full SHA for fb1260a

Commits on Jan 27, 2023

• Added invitation processing to Invitee and moved some Connection methods to their appropriate types

  Show description for f48c429
  bobozaur

  committed
  f48c429

  Copy full SHA for f48c429

• Renamed SerdeCon to VagueConnection. This will be used for deserialization only

  Show description for 18b0f4c
  bobozaur

  committed
  18b0f4c

  Copy full SHA for 18b0f4c

• Added dedicated serialization types for borrowed serialization of Connection and implemented Serialize

  Show description for 6ea03e7
  bobozaur

  committed
  6ea03e7

  Copy full SHA for 6ea03e7

• Fixed Connection serialization trait bounds

  Show description for 3b51586
  bobozaur

  committed
  3b51586

  Copy full SHA for 3b51586

• Reverted to using invitation ID as thread ID

  Show description for 9280633
  bobozaur

  committed
  9280633

  Copy full SHA for 9280633

• Added direct deserialization support to Connection through try_from impl of VagueConnection

  Show description for 1927b5e
  bobozaur

  committed
  1927b5e

  Copy full SHA for 1927b5e

• Set typestate_con states attributes pub(crate)

  Show description for ccbdb78
  bobozaur

  committed
  ccbdb78

  Copy full SHA for ccbdb78

• Added typestate_con libvcx implementation draft

  Show description for 792c4a6
  bobozaur

  committed
  792c4a6

  Copy full SHA for 792c4a6

Commits on Jan 29, 2023

• Completed typestate_con implementation in libvcx

  Show description for 0574540
  bobozaur

  committed
  0574540

  Copy full SHA for 0574540

Commits on Jan 30, 2023

• Renamed remove_connection in libvcx to get_cloned_connection and implemented cloning to persist previous state in the cache

  Show description for 6f65e34
  bobozaur

  committed
  6f65e34

  Copy full SHA for 6f65e34

• Removed the lazy_static HTTPCLIENT in favor of using the ZST directly

  Show description for ebba648
  bobozaur

  committed
  ebba648

  Copy full SHA for ebba648

• Retro-fitted the process_request and send_response methods for backwards compatibility

  Show description for cf7b88b
  bobozaur

  committed
  cf7b88b

  Copy full SHA for cf7b88b

• Added ProblemReport generation and sending

  Show description for ea14d58
  bobozaur

  committed
  ea14d58

  Copy full SHA for ea14d58

• Added test From implementations between SerializableConnection and VagueConnection for compile-time check that types match

  Show description for b81b2b6
  bobozaur

  committed
  b81b2b6

  Copy full SHA for b81b2b6

• Added boilerplate macro for From impls for SerializationConnection

  Show description for 7595bbe
  bobozaur

  committed
  7595bbe

  Copy full SHA for 7595bbe

Commits on Jan 31, 2023

• Modified aries-vcx-agent to use typestate connections

  Show description for ef29fbe
  bobozaur

  committed
  ef29fbe

  Copy full SHA for ef29fbe

Commits on Feb 1, 2023

• Fixed method rename in libvcx

  Show description for f4e677e
  bobozaur

  committed
  f4e677e

  Copy full SHA for f4e677e

• Removed send_invitation method

  Show description for 6234370
  bobozaur

  committed
  6234370

  Copy full SHA for 6234370

• Typestate connection cosmetic changes, comments, and modules re-organization

  Show description for c060847
  bobozaur

  committed
  c060847

  Copy full SHA for c060847

• Removed previous non-mediated Connection in favor of newer typestate Connection

  Show description for 1abda21
  bobozaur

  committed
  1abda21

  Copy full SHA for 1abda21

• Fixed state differences in Node.js wrapper

  Show description for 7c932e5
  bobozaur

  committed
  7c932e5

  Copy full SHA for 7c932e5

• Reuse request did_doc

  Show description for 695305a
  bobozaur

  committed
  695305a

  Copy full SHA for 695305a

• Moved Transport trait and auto-implemented for references of types implementing it

  Show description for e88ce9e
  bobozaur

  committed
  e88ce9e

  Copy full SHA for e88ce9e

• Fix FFI wrapper to return a Promise for the async request handling

  Show description for e30200d
  bobozaur

  committed
  e30200d

  Copy full SHA for e30200d

Commits on Feb 2, 2023

• Reverting dependencies in vcxagent-core

  Show description for b839c86
  bobozaur

  committed
  b839c86

  Copy full SHA for b839c86

• Ignore dist dirs

  Show description for b2ce58e
  bobozaur

  committed
  b2ce58e

  Copy full SHA for b2ce58e

• Reverted NAPI changes and mimicked old connection states more accurately for backwards compatibility

  Show description for 876a099
  bobozaur

  committed
  876a099

  Copy full SHA for 876a099

• Fixed accept_invitation log comment and added more explicit logs to libvcx

  Show description for f2f8e5a
  bobozaur

  committed
  f2f8e5a

  Copy full SHA for f2f8e5a

• processInvite is now a Promise

  Show description for 5cb9f83
  bobozaur

  committed
  5cb9f83

  Copy full SHA for 5cb9f83

• Fixed thread_id handling when accepting invitation and sending request as an invitee

  Show description for 43c8c95
  bobozaur

  committed
  43c8c95

  Copy full SHA for 43c8c95

Commits on Feb 3, 2023

• More state retro-fitting with previous implementation

  Show description for 6e96c55
  bobozaur

  committed
  6e96c55

  Copy full SHA for 6e96c55

• Fix thread_id usage in Request generation

  Show description for 88e66f2
  bobozaur

  committed
  88e66f2

  Copy full SHA for 88e66f2

• Added comments

  Show description for 1324b59
  bobozaur

  committed
  1324b59

  Copy full SHA for 1324b59

• Added concrete and generic connection serialization and deserialization tests

  Show description for ca3ddcc
  bobozaur

  committed
  ca3ddcc

  Copy full SHA for ca3ddcc

• Added whitespace in libcx

  Show description for 64fc633
  bobozaur

  committed
  64fc633

  Copy full SHA for 64fc633

• Ran cargo fmt

  Show description for 05f0303
  bobozaur

  committed
  05f0303

  Copy full SHA for 05f0303

Commits on Feb 7, 2023

• Completely separated states between invitee and inviter

  Show description for 2d5145a
  bobozaur

  committed
  2d5145a

  Copy full SHA for 2d5145a

• Added BootstrapDidDoc trait

  Show description for 1541771
  bobozaur

  committed
  1541771

  Copy full SHA for 1541771

• Added non-mediated connection OOB handling

  Show description for 079f742
  bobozaur

  committed
  079f742

  Copy full SHA for 079f742

• Improved OOB connection existence look-up and implemented libvcx non-mediated connection calls

  Show description for 2fdef4f
  bobozaur

  committed
  2fdef4f

  Copy full SHA for 2fdef4f

• Implemented necessary changes to node wrappers to expose non-mediated connections

  Show description for 6ee9d09
  bobozaur

  committed
  6ee9d09

  Copy full SHA for 6ee9d09

• Unexposed internal OOB method

  Show description for 98e4a50
  bobozaur

  committed
  98e4a50

  Copy full SHA for 98e4a50

• Added re-export of PairwiseInfo to mediatedconnection to avoid struct duplication

  Show description for 26a2441
  bobozaur

  committed
  26a2441

  Copy full SHA for 26a2441

• Ran cargo fmt

  Show description for 4675cb5
  bobozaur

  committed
  4675cb5

  Copy full SHA for 4675cb5

• Fixed GenericConnection doc test and comment

  Show description for ece4d8a
  bobozaur

  committed
  ece4d8a

  Copy full SHA for ece4d8a

• Made processInvite in node wrapper async

  Show description for 307ae05
  bobozaur

  committed
  307ae05

  Copy full SHA for 307ae05

Commits on Feb 8, 2023

• Fixed comments typos

  Show description for a34ff89
  bobozaur

  committed
  a34ff89

  Copy full SHA for a34ff89

• Added more comments to Connection::into_invited

  Show description for c960830
  bobozaur

  committed
  c960830

  Copy full SHA for c960830

• Added comments to Connection::get_invitation

  Show description for 674015b
  bobozaur

  committed
  674015b

  Copy full SHA for 674015b

• Accommodated previous send_message behavior

  Show description for 607b1dd
  bobozaur

  committed
  607b1dd

  Copy full SHA for 607b1dd

• Factored out read access to CONNECTION_MAP in libvcx into a closure accepting function

  Show description for 8ff5041
  bobozaur

  committed
  8ff5041

  Copy full SHA for 8ff5041

• Fixed wrapper send_message and added send_aries_message

  Show description for 3eba85b
  bobozaur

  committed
  3eba85b

  Copy full SHA for 3eba85b

• Fixed comment link

  Show description for eacc08d
  bobozaur

  committed
  eacc08d

  Copy full SHA for eacc08d

• Updated napi and napi-derive dependencies version

  Show description for 735c302
  bobozaur

  committed
  735c302

  Copy full SHA for 735c302

Commits on Feb 9, 2023

• Made from_parts public and added into_parts method on Connection

  Show description for afd198d
  bobozaur

  committed
  afd198d

  Copy full SHA for afd198d

• Made node wrapper serialize a connection as a JSON object instead of string

  Show description for 3cb83fb
  bobozaur

  committed
  3cb83fb

  Copy full SHA for 3cb83fb