Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not bind to vdrtools FFI in ios wrapper #723

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jan 7, 2023

  • Ios wrapper contains links to vdrtools FFI functions - this PR is removing functions which links to vdrtools symbols (which are included, if vdrtools feature ffi_api is enabled).
  • Ios wrapper should only use API directly exposed by libvcx
  • Consequently we no longer use vdrtools feature ffi_api

Signed-off-by: Patrik Stas patrik.stas@absa.africa

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner January 7, 2023 00:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #723 (d5eb916) into main (93de484) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   64.30%   64.39%   +0.09%     
==========================================
  Files         245      244       -1     
  Lines       22911    22828      -83     
  Branches     5086     5064      -22     
==========================================
- Hits        14733    14701      -32     
+ Misses       4035     4003      -32     
+ Partials     4143     4124      -19     
Flag Coverage Δ
unittests-aries-vcx 64.25% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/errors/mapping_vdrtools.rs 39.39% <0.00%> (-12.78%) ⬇️
aries_vcx/src/common/proofs/prover/prover.rs 48.57% <0.00%> (-2.86%) ⬇️
aries_vcx/src/indy/proofs/verifier/verifier.rs 61.11% <0.00%> (-2.05%) ⬇️
aries_vcx/src/indy/signing.rs 61.11% <0.00%> (-1.86%) ⬇️
...ies_vcx/src/indy/primitives/revocation_registry.rs 58.26% <0.00%> (-0.87%) ⬇️
...s_vcx/src/common/primitives/revocation_registry.rs 48.82% <0.00%> (-0.59%) ⬇️
aries_vcx/src/common/ledger/transactions.rs 62.32% <0.00%> (-0.36%) ⬇️
aries_vcx/src/indy/wallet.rs 38.15% <0.00%> (-0.31%) ⬇️
messages/src/a2a/mod.rs 61.53% <0.00%> (-0.20%) ⬇️
.../src/protocols/connection/inviter/state_machine.rs 72.53% <0.00%> (-0.18%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@gmulhearn
Copy link
Contributor

gmulhearn commented Jan 9, 2023

Hey @Patrik-Stas could you please add a little description context to this PR? - Mostly for my own education.

Did the libvdrtools ffi_api feature expose some C functions which the iOS Indy... Header files would target within the libvcx.a binary? And now the intention is to move away from having any of those direct indy functions in the wrappers?

@Patrik-Stas
Copy link
Contributor Author

Patrik-Stas commented Jan 9, 2023

Hey @Patrik-Stas could you please add a little description context to this PR? - Mostly for my own education.

Did the libvdrtools ffi_api feature expose some C functions which the iOS Indy... Header files would target within the libvcx.a binary? And now the intention is to move away from having any of those direct indy functions in the wrappers?

apologies for missing PR description, added here as well as on my other recent PRs. Nevertheless your understanding is precisely correct.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the ios/simplify-vdrtools-dep branch from 6106f17 to d5eb916 Compare January 10, 2023 10:12
@Patrik-Stas Patrik-Stas mentioned this pull request Jan 10, 2023
@mirgee mirgee merged commit 0fb6f28 into main Jan 10, 2023
@mirgee mirgee deleted the ios/simplify-vdrtools-dep branch January 10, 2023 12:42
@Patrik-Stas Patrik-Stas changed the title Remove usage of vdrtools's ffi_api feature Do not bind to vdrtools FFI in ios wrapper Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants