Improve mappings from vdrtools, refactor tests in libvcx

[Patrik-Stas]

Changes

• Adjust IndyErrorKind -> AriesVcxErrorKind to more sensible mapping
• Add new LedgerItemNotFound err kind to ariesvcx, libvcx
• Add new ObjectAccessError err kind to libvcx
• Fix wrong err handling - it wrong key is used to open wallet, throw LibvcxErrorKind::WalletAccessFailed err kind instead of "unmapped" libindy error LibvcxErrorKind::LibndyError(207). Added test to libvcx to cover this case

Refactoring

• Move tests from api_c layer to api_vcx
• Delete dead code

Signed-off-by: Patrik Stas patrik.stas@absa.africa

[codecov-commenter]

Codecov Report

Merging #721 (a7d7031) into main (0c8eb58) will increase coverage by 0.09%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   64.30%   64.39%   +0.09%     
==========================================
  Files         245      244       -1     
  Lines       22911    22828      -83     
  Branches     5072     5070       -2     
==========================================
- Hits        14732    14701      -31     
+ Misses       4035     4003      -32     
+ Partials     4144     4124      -20     

Flag	Coverage Δ
unittests-aries-vcx	64.25% <18.75%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...vcx/src/common/primitives/credential_definition.rs	50.50% <0.00%> (ø)
aries_vcx/src/common/proofs/verifier/verifier.rs	83.94% <ø> (ø)
aries_vcx/src/errors/error.rs	43.24% <ø> (ø)
aries_vcx/src/indy/anoncreds.rs	71.73% <ø> (+4.39%)	⬆️
aries_vcx/src/indy/ledger/transactions.rs	53.86% <ø> (+1.90%)	⬆️
...ies_vcx/src/indy/primitives/revocation_registry.rs	58.26% <ø> (-0.87%)	⬇️
aries_vcx/src/indy/utils/mod.rs	60.60% <ø> (ø)
aries_vcx/src/plugins/ledger/indy_vdr_ledger.rs	44.37% <ø> (+0.92%)	⬆️
aries_vcx/src/utils/devsetup.rs	73.74% <0.00%> (ø)
...ries_vcx/src/utils/mockdata/profile/mock_ledger.rs	25.96% <0.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gmulhearn]

lgtm, just the one comment