-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme.md files, update architecture diagram #719
Conversation
Codecov Report
@@ Coverage Diff @@
## main #719 +/- ##
===========================================
- Coverage 64.34% 45.29% -19.05%
===========================================
Files 245 242 -3
Lines 22837 17652 -5185
Branches 5074 3448 -1626
===========================================
- Hits 14694 7996 -6698
- Misses 4017 7306 +3289
+ Partials 4126 2350 -1776
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a couple comments
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
c81b846
to
93fd08a
Compare
readme.md
is more general and alsoaries-vcx
along with the smaller subcrates as main componentslibvcx
is nuanced as "one of the crates built on aries-vcx"libvcx
aries-vcx
aries-vcx
crate architecture onlylibvcx
and surrounding language wrappers, depictingaries-vcx
simply as 1 componentSigned-off-by: Patrik Stas patrik.stas@absa.africa