Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AriesVCX CLI POC #692

Closed
wants to merge 2 commits into from
Closed

AriesVCX CLI POC #692

wants to merge 2 commits into from

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Dec 10, 2022

An experimental AriesVCX command line interface proof-of-concept, built on top of aries-vcx-agent. There is not much in terms of functionality at the moment, except for writing schema and cred def, establishing connection, listing connections, listing and reacting to received messages. There is plenty of room for improvement (logging, for one), but at the same time, this PR provides a blueprint which can be easily improved and extended with further functionality.

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added enhancement New feature or request agents labels Dec 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Merging #692 (504533b) into main (9b9969b) will decrease coverage by 1.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   54.65%   53.23%   -1.42%     
==========================================
  Files         381      381              
  Lines       36852    36852              
  Branches     8136     8110      -26     
==========================================
- Hits        20142    19620     -522     
- Misses      10713    11496     +783     
+ Partials     5997     5736     -261     
Flag Coverage Δ
unittests-aries-vcx 53.14% <ø> (-1.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -0,0 +1,4 @@
{"reqSignature":{},"txn":{"data":{"data":{"alias":"Node1","blskey":"4N8aUNHSgjQVgkpm8nhNEfDf6txHznoYREg9kirmJrkivgL4oSEimFF6nsQ6M41QvhM2Z33nves5vfSn9n1UwNFJBYtWVnHYMATn76vLuL3zU88KyeAYcHfsih3He6UHcXDxcaecHVz6jhCYz1P2UZn2bDVruL5wXpehgBfBaLKm3Ba","blskey_pop":"RahHYiCvoNCtPTrVtP7nMC5eTYrsUA8WjXbdhNc8debh1agE9bGiJxWBXYNFbnJXoXhWFMvyqhqhRoq737YQemH5ik9oL7R4NTTCz2LEZhkgLJzB3QRQqJyBNyv7acbdHrAT8nQ9UkLbaVL9NBpnWXBTw4LEMePaSHEw66RzPNdAX1","client_ip":"127.0.0.1","client_port":9702,"node_ip":"127.0.0.1","node_port":9701,"services":["VALIDATOR"]},"dest":"Gw6pDLhcBcoQesN72qfotTgFa7cbuqZpkX3Xo6pLhPhv"},"metadata":{"from":"Th7MpTaRZVRYnPiabds81Y"},"type":"0"},"txnMetadata":{"seqNo":1,"txnId":"fea82e10e894419fe2bea7d96296a6d46f50f93f9eeda954ec461b2ed2950b62"},"ver":"1"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we could make small rust crate containing these, similar to https://github.com/AbsaOSS/sovrin-networks
Would be handy in aries rust project

@Patrik-Stas
Copy link
Contributor

Really cool :-)

Would be nice to dockerize this and then run it from https://www.docker.com/play-with-docker/ :-) Online ephemeral CLI aries client

@gmulhearn gmulhearn marked this pull request as ready for review February 19, 2023 09:36
@gmulhearn gmulhearn marked this pull request as draft February 19, 2023 09:36
@mirgee mirgee closed this Mar 31, 2023
@mirgee mirgee deleted the feature/aries-vcx-cli branch April 1, 2023 07:20
@Patrik-Stas Patrik-Stas restored the feature/aries-vcx-cli branch June 5, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants