Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libc as aries-vcx dependency #657

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

Patrik-Stas
Copy link
Contributor

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@Patrik-Stas Patrik-Stas requested a review from a team as a code owner November 20, 2022 18:23
@Patrik-Stas Patrik-Stas force-pushed the dependencies/remove-libvc branch from 628a1e0 to 75236ac Compare November 20, 2022 18:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Merging #657 (75236ac) into main (7a7c65d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   64.01%   64.02%           
=======================================
  Files         215      215           
  Lines       20574    20574           
  Branches     4615     4617    +2     
=======================================
+ Hits        13170    13172    +2     
  Misses       3894     3894           
+ Partials     3510     3508    -2     
Flag Coverage Δ
unittests-aries-vcx 63.82% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/tests/utils/scenarios.rs 82.10% <0.00%> (ø)
...vcx/src/protocols/issuance/issuer/state_machine.rs 69.45% <0.00%> (+0.12%) ⬆️
aries_vcx/tests/test_connection.rs 75.40% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

left-arm
left-arm previously approved these changes Nov 20, 2022
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@mirgee mirgee merged commit 597d5f6 into main Nov 22, 2022
@mirgee mirgee deleted the dependencies/remove-libvc branch November 22, 2022 15:16
gmulhearn-anonyome pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants