Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default presentation preview message family #590

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 5, 2022

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

mirgee added 2 commits October 4, 2022 18:25
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added the hotfix High priority fixes of unexpected issues label Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #590 (80410e1) into hotfix/cred-preview-serialization (f12c68e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                        Coverage Diff                         @@
##           hotfix/cred-preview-serialization     #590   +/-   ##
==================================================================
  Coverage                              59.78%   59.78%           
==================================================================
  Files                                    139      139           
  Lines                                  15620    15620           
  Branches                                3627     3627           
==================================================================
+ Hits                                    9338     9339    +1     
  Misses                                  2408     2408           
+ Partials                                3874     3873    -1     
Flag Coverage Δ
integration-aries-vcx 52.47% <ø> (ø)
unittests-agency-client 25.45% <ø> (ø)
unittests-aries-vcx 52.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vcx/src/protocols/issuance/issuer/state_machine.rs 72.01% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirgee mirgee marked this pull request as ready for review October 5, 2022 19:13
@mirgee mirgee requested a review from a team as a code owner October 5, 2022 19:13
Base automatically changed from hotfix/cred-preview-serialization to main October 5, 2022 21:29
@Patrik-Stas Patrik-Stas merged commit 78b3e42 into main Oct 5, 2022
@Patrik-Stas Patrik-Stas deleted the hotfix/default-presentation-preview-family branch October 5, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix High priority fixes of unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants