Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding extra quotes when building offer from proposal in array format #589

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 4, 2022

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added the hotfix High priority fixes of unexpected issues label Oct 4, 2022
@mirgee mirgee requested a review from a team as a code owner October 4, 2022 16:30
@codecov-commenter
Copy link

Codecov Report

Merging #589 (f12c68e) into main (6f163ef) will decrease coverage by 9.90%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   59.77%   49.87%   -9.91%     
==========================================
  Files         139      138       -1     
  Lines       15604    11022    -4582     
  Branches     3625     2109    -1516     
==========================================
- Hits         9328     5497    -3831     
- Misses       2405     3614    +1209     
+ Partials     3871     1911    -1960     
Flag Coverage Δ
integration-aries-vcx ?
unittests-agency-client 25.45% <ø> (ø)
unittests-aries-vcx 52.56% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/issuance/issuer.rs 54.05% <66.66%> (-4.48%) ⬇️
...tocols/proof_presentation/prover/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
aries_vcx/src/handlers/discovery/mod.rs 0.00% <0.00%> (-87.10%) ⬇️
aries_vcx/src/indy/test_utils.rs 0.00% <0.00%> (-82.94%) ⬇️
aries_vcx/tests/utils/scenarios.rs 0.00% <0.00%> (-71.14%) ⬇️
aries_vcx/src/utils/provision.rs 0.00% <0.00%> (-68.43%) ⬇️
aries_vcx/tests/utils/devsetup_agent.rs 0.00% <0.00%> (-61.23%) ⬇️
...ies_vcx/src/indy/primitives/revocation_registry.rs 0.00% <0.00%> (-47.48%) ⬇️
aries_vcx/src/utils/random.rs 52.94% <0.00%> (-47.06%) ⬇️
aries_vcx/src/indy/wallet_non_secrets.rs 0.00% <0.00%> (-43.48%) ⬇️
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Patrik-Stas Patrik-Stas merged commit 9b20430 into main Oct 5, 2022
@Patrik-Stas Patrik-Stas deleted the hotfix/cred-preview-serialization branch October 5, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix High priority fixes of unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants