Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder pattern in agency client configuration #588

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Sep 30, 2022

Allows constructing agency client more eloquently as

let agency_client = AgencyClient::new().configure(&agency_client_config)?;

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added the hotfix High priority fixes of unexpected issues label Sep 30, 2022
@mirgee mirgee requested a review from a team as a code owner September 30, 2022 10:39
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #588 (3ec3ec6) into main (e60c74d) will not change coverage.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   59.77%   59.77%           
=======================================
  Files         139      139           
  Lines       15604    15604           
  Branches     3625     3625           
=======================================
  Hits         9328     9328           
  Misses       2405     2405           
  Partials     3871     3871           
Flag Coverage Δ
integration-aries-vcx 52.47% <50.00%> (ø)
unittests-agency-client 25.45% <0.00%> (ø)
unittests-aries-vcx 52.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agency_client/src/agency_client.rs 24.19% <0.00%> (ø)
aries_vcx/tests/test_agency.rs 55.67% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Patrik-Stas Patrik-Stas merged commit 6f163ef into main Sep 30, 2022
@Patrik-Stas Patrik-Stas deleted the hotfix/agency-client-builder branch September 30, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix High priority fixes of unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants