Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove declaration of unused variables #380

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

Patrik-Stas
Copy link
Contributor

Signed-off-by: Patrik Stas patrik.stas@absa.africa

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner November 19, 2021 16:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #380 (8d2c57a) into main (a318ce2) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   66.19%   66.39%   +0.20%     
==========================================
  Files         154      153       -1     
  Lines       14583    14454     -129     
  Branches     2877     2861      -16     
==========================================
- Hits         9653     9597      -56     
+ Misses       2593     2535      -58     
+ Partials     2337     2322      -15     
Flag Coverage Δ
integration-aries-vcx 53.29% <ø> (+0.07%) ⬆️
unittests-agency-client 22.51% <ø> (ø)
unittests-aries-vcx 48.62% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/handlers/connection/invitee/states/requested.rs 36.36% <0.00%> (-18.19%) ⬇️
aries_vcx/src/messages/thread.rs 61.53% <0.00%> (-5.74%) ⬇️
...ssages/proof_presentation/presentation_proposal.rs 63.38% <0.00%> (-5.09%) ⬇️
aries_vcx/src/handlers/issuance/issuer/issuer.rs 72.61% <0.00%> (-3.39%) ⬇️
.../src/handlers/connection/invitee/states/invited.rs 57.14% <0.00%> (-2.86%) ⬇️
aries_vcx/src/messages/discovery/disclose.rs 80.55% <0.00%> (-1.95%) ⬇️
...ndlers/issuance/issuer/states/proposal_received.rs 94.73% <0.00%> (-1.82%) ⬇️
aries_vcx/src/messages/connection/request.rs 83.67% <0.00%> (-1.44%) ⬇️
...x/src/handlers/connection/invitee/state_machine.rs 75.10% <0.00%> (-1.20%) ⬇️
.../src/handlers/issuance/issuer/states/offer_sent.rs 64.70% <0.00%> (-1.09%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a318ce2...8d2c57a. Read the comment docs.

@mirgee mirgee merged commit 3ab9ebc into main Nov 19, 2021
@mirgee mirgee deleted the ci/ios-simplify-build branch November 19, 2021 22:43
@mirgee mirgee added the ci label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants