Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12.0 #168

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Release 0.12.0 #168

merged 3 commits into from
Oct 27, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 23, 2020

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

@Patrik-Stas
Copy link
Contributor

@mirgee we should deprecate function we wanted to deprecate - old update states, message download and additionally I think we should also deprecate vcx_init_with_config and vcx_init_minimal. So there would be only 1 way of initializing - init_core+open_pool+open_wallet.
Then on next release we could delete these deprecated apis.

@Patrik-Stas
Copy link
Contributor

I would also suggest bumping to 0.12.0, we added couple new APIs and strictly speaking, this #137 was actually breaking change - input which would previously be valid is not valid anymore (altough chance of someone running into that particular case are miniscule)

@mirgee mirgee changed the title Release 0.11.1 Release 0.12.0 Oct 26, 2020
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #168 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   51.13%   51.12%   -0.02%     
==========================================
  Files         150      150              
  Lines       22914    22914              
  Branches     6051     6051              
==========================================
- Hits        11718    11715       -3     
- Misses       7589     7594       +5     
+ Partials     3607     3605       -2     
Flag Coverage Δ
#unittests 51.12% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/credential.rs 37.44% <ø> (ø)
libvcx/src/api/disclosed_proof.rs 42.37% <ø> (ø)
libvcx/src/api/issuer_credential.rs 38.70% <ø> (ø)
libvcx/src/api/proof.rs 52.86% <ø> (ø)
libvcx/src/api/vcx.rs 57.77% <ø> (ø)
libvcx/src/lib.rs 33.45% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f17f81...bbf4f02. Read the comment docs.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas merged commit 28e1084 into master Oct 27, 2020
@Patrik-Stas Patrik-Stas deleted the release/0.11.1 branch October 27, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants